Fix Loggers

[Raffaello]

Summary by CodeRabbit

• New Features
  • Improved packaging when optional logging support is enabled, including install/export of the logging and formatting libraries alongside the main driver library.
  • Updated the project release version to 0.19.6.
• Bug Fixes
  • SDL log messages are now routed through the configured application logger immediately on logger creation (SDL2/SDL3).
  • SDL log routing is properly restored when the logger is destroyed.
• Chores
  • Updated spell-check allowlist for SDLCALL.
  • Adjusted SonarCloud CI Java setup on Windows to ensure the correct toolchain is used.

[coderabbitai]

Warning

Review limit reached

@Raffaello, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 75fc0c71-51ba-431c-a765-6da869a3440b

📥 Commits

Reviewing files that changed from the base of the PR and between 7e08263 and 5a91623.

📒 Files selected for processing (2)

• .github/workflows/ci-sonarcloud.yml
• cspell.json

Walkthrough

The project version is incremented to 0.19.6, optional fmt and spdlog packaging exports are expanded, SonarCloud uses explicit Java 21 environment settings, and SDL2/SDL3 loggers now activate custom output during construction and restore prior routing during teardown.

Changes

Build and packaging

Layer / File(s)	Summary
Version and optional dependency packaging CMakeLists.txt, hyper-sonic-drivers/CMakeLists.txt	The project version changes to 0.19.6, and USE_SPDLOG packaging conditionally installs and exports fmt, spdlog, and spdlog artifacts.
SonarCloud Java environment .github/workflows/ci-sonarcloud.yml	The workflow explicitly sets Java 21 environment variables and prepends the Java binary directory to PATH for the SonarCloud build wrapper.

SDL logging initialization

Layer / File(s)	Summary
SDL callback lifecycle hyper-sonic-drivers/src/HyperSonicDrivers/utils/sdl2/Logger.cpp, hyper-sonic-drivers/src/HyperSonicDrivers/utils/sdl3/Logger.cpp, cspell.json	SDL2 and SDL3 loggers install custom callbacks during construction, restore captured defaults during teardown, use the SDL calling convention, and allowlist the new terminology.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

• Raffaello/hyper-sonic-drivers#295: Modifies the SDL2 and SDL3 logger implementations.
• Raffaello/hyper-sonic-drivers#297: Modifies the USE_SPDLOG CMake packaging area.
• Raffaello/hyper-sonic-drivers#308: Modifies the top-level project version declaration.

Poem

A rabbit hops through CMake’s door,
fmt and spdlog pack a little more.
SDL logs wake at dawn,
Then restore the path they’re on.
Java guides the build just right—
“0.19.6!” we cheer tonight.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: logger behavior was fixed in both SDL2 and SDL3 implementations.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch logger

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[Raffaello]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.