Fix terminal history, prompt routing, and state edge cases - #63
Merged
Conversation
- persistence: drop the 500-block load window; `load_blocks` now restores the entire transcript, relying on the renderer to virtualize deep history instead of truncating it on disk read. - term/warp_term/frontend: `raw_input` now also fires when ECHO is cleared (not just ICANON), so password/token prompts that keep canonical line buffering still route straight to the PTY instead of the visible block editor. - inputModeDecision: add `classifyPromptSubmission` to distinguish a new shell command from stdin for a still-running foreground prompt.
Add regression tests covering these state/reducer and lib fixes.
# Conflicts: # src-tauri/src/term.rs # src/terminal/BlockTerminal.tsx
Raeedzz
marked this pull request as ready for review
July 15, 2026 20:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Several independent edge cases could lose visible terminal history, send sensitive prompt input through the wrong editor, leave a hidden terminal input active after process exit, or create inconsistent project and branch state. The fixes address the underlying state and terminal-mode decisions rather than masking their UI symptoms.
Impact
Users retain their full saved terminal history, password and token prompts behave correctly, project lists remain stable across equivalent paths and delayed actions, URLs open intact, and generated branch prefixes avoid unsafe punctuation.
Validation
git diff --checkpassedNotes
cargo clippy -- -D warningsstill reports existing style lints and vendored macOS deprecation warnings unrelated to this change.