Revert PR #6: 3D trough rendering - #7
Merged
Conversation
The 3D trough rendering didn't read as intended in the live preview. Reverting to the 2D outlined triangle from PR #5 while we explore a measuring-stick approach instead. Trough work is preserved in git history (PR #6 / branch trough-rendering) should we want to revisit. This reverts commit 7b0901b, reversing changes made to 2619e75.
✅ Deploy Preview for silly-starship-9969f8 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #6 (3D trough rendering). The visual didn't read as intended in the live preview, so we're returning
mainto the 2D outlined triangle from #5 (intro copy) while we explore a measuring-stick approach in a separate PR.The trough work is preserved in git history (PR #6 commit
7b0901band branchtrough-rendering) — the revert is itself a normal commit that could be re-reverted later if we ever want to revisit.How
git revert -m 1 7b0901b(mainline parent = 1, since #6 was a merge commit). No manual file edits.Diff
Only
src/components/Funnel.tsxis touched, and only by the revert: 99 insertions / 298 deletions, exactly the inverse of #6.Intro.tsx,Explainer.tsx,LiquidQV.tsx,PageChrome.tsx, the math layer, the reducer, and all tests are unchanged.Verified
tsc -b --noEmitclean.Don't merge
Per the round's brief: hold for review.
🤖 Generated with Claude Code