Skip to content

fix(#259): docker-compose error on building sample project.#260

Open
NaGaii1994 wants to merge 2 commits intoRadi85:developfrom
NaGaii1994:fix/docker-build-error
Open

fix(#259): docker-compose error on building sample project.#260
NaGaii1994 wants to merge 2 commits intoRadi85:developfrom
NaGaii1994:fix/docker-build-error

Conversation

@NaGaii1994
Copy link
Copy Markdown
Contributor

  • Change base image from alpine to slim-bullseye because using alpine can make python docker slower.
  • Update postgres image from 9.6 to 14.
  • Fix bug that django container connect database before database is ready.

Copy link
Copy Markdown
Collaborator

@abhiabhi94 abhiabhi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @NaGaii1994 thanks for taking the time to contribute. left some comments, rest of the patch looks fine to me.

Comment thread Dockerfile
Comment thread test/example/requirements.txt Outdated
NaGaii1994 added a commit to NaGaii1994/Comment that referenced this pull request Nov 5, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 5, 2022

Codecov Report

Base: 99.89% // Head: 99.89% // No change to project coverage 👍

Coverage data is based on head (02ee66a) compared to base (0d600b9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #260   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files           56       56           
  Lines         1994     1994           
  Branches       162      161    -1     
========================================
  Hits          1992     1992           
  Misses           1        1           
  Partials         1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NaGaii1994 NaGaii1994 force-pushed the fix/docker-build-error branch from 8431597 to 02ee66a Compare November 5, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants