fix(#259): docker-compose error on building sample project.#260
Open
NaGaii1994 wants to merge 2 commits intoRadi85:developfrom
Open
fix(#259): docker-compose error on building sample project.#260NaGaii1994 wants to merge 2 commits intoRadi85:developfrom
NaGaii1994 wants to merge 2 commits intoRadi85:developfrom
Conversation
Contributor
NaGaii1994
commented
Nov 3, 2022
- Change base image from alpine to slim-bullseye because using alpine can make python docker slower.
- Update postgres image from 9.6 to 14.
- Fix bug that django container connect database before database is ready.
abhiabhi94
reviewed
Nov 5, 2022
Collaborator
abhiabhi94
left a comment
There was a problem hiding this comment.
hey @NaGaii1994 thanks for taking the time to contribute. left some comments, rest of the patch looks fine to me.
NaGaii1994
added a commit
to NaGaii1994/Comment
that referenced
this pull request
Nov 5, 2022
Codecov ReportBase: 99.89% // Head: 99.89% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #260 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 56 56
Lines 1994 1994
Branches 162 161 -1
========================================
Hits 1992 1992
Misses 1 1
Partials 1 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8431597 to
02ee66a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.