Skip to content

BUG: Use max corner angle in Parker weighting warning check #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
axel-grc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: Use max corner angle in Parker weighting warning check #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions include/rtkParkerShortScanImageFilter.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,15 +95,15 @@ ParkerShortScanImageFilter<TInputImage, TOutputImage>::GenerateInputRequestedReg
double invsid = 1. / sqrt(sid * sid + sox * sox);

// Check that Parker weighting is relevant for this projection
double halfDetectorWidth1 = std::abs(m_Geometry->ToUntiltedCoordinateAtIsocenter(k, corner1[0]));
double halfDetectorWidth2 = std::abs(m_Geometry->ToUntiltedCoordinateAtIsocenter(k, corner2[0]));
double halfDetectorWidth = std::min(halfDetectorWidth1, halfDetectorWidth2);
if (m_Delta < atan(halfDetectorWidth * invsid))
double halfBeamAngle =
std::max(std::abs(atan(m_Geometry->ToUntiltedCoordinateAtIsocenter(k, corner1[0]) * invsid)),
std::abs(atan(m_Geometry->ToUntiltedCoordinateAtIsocenter(k, corner2[0]) * invsid)));
if (m_Delta < halfBeamAngle)
{
itkWarningMacro(<< "You do not have enough data for proper Parker weighting (short scan)"
<< " according to projection #" << k << ". Delta is " << m_Delta * 180. / itk::Math::pi
<< " degrees and should be more than half the beam angle, i.e. "
<< atan(halfDetectorWidth * invsid) * 180. / itk::Math::pi << " degrees.");
<< halfBeamAngle * 180. / itk::Math::pi << " degrees.");
return;
}
}
Expand Down