Skip to content

Use hash of test files instead of unique ID - #102

Open
acoussat wants to merge 1 commit into
RTKConsortium:mainfrom
acoussat:test-files-hash
Open

acoussat wants to merge 1 commit into
RTKConsortium:mainfrom
acoussat:test-files-hash

Conversation

@acoussat

Copy link
Copy Markdown
Collaborator

Unique ID does not change when content of file changes, unlike the hash. Using the hash is more robust as it allows several versions or branches of PCT to use their own test files.

Unique ID does not change when content of file changes, unlike the hash.
Using the hash is more robust as it allows several versions or branches of PCT to use their own test files.

@SimonRit SimonRit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suppose the failing Python test is not caused by this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants