ENH: Add unit tests to increase coverage - #103
Merged
Merged
Conversation
axel-grc
force-pushed
the
CoverageTests
branch
from
August 27, 2026 08:59
6ccf888 to
384bfc8
Compare
axel-grc
force-pushed
the
CoverageTests
branch
from
August 31, 2026 08:36
384bfc8 to
b235a49
Compare
SimonRit
approved these changes
Aug 31, 2026
Comment on lines
+37
to
+51
| bool threw = false; | ||
| try | ||
| { | ||
| mgr->Update(); | ||
| } | ||
| catch (itk::ExceptionObject &) | ||
| { | ||
| threw = true; | ||
| } | ||
| if (!threw) | ||
| { | ||
| std::cerr << "Update should throw when both buffers are dirty" << std::endl; | ||
| delete[] cpuBuf; | ||
| return EXIT_FAILURE; | ||
| } |
Collaborator
There was a problem hiding this comment.
Can you check if this can be done with ITK macros? Here ITK_TRY_EXPECT_EXCEPTION.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.