chore(ci): add cargo-deny, deny warnings, and dependency policy fixes#59
Merged
Conversation
sgopinath1
requested review from
powderluv,
shiv-tyagi and
yansun1996
as code owners
There was a problem hiding this comment.
Pull request overview
This PR tightens the Rust CI and dependency policy for spur-cloud by introducing cargo-deny checks, enforcing -D warnings, and updating dependency metadata/lockfile to satisfy advisory and policy requirements.
Changes:
- Add
cargo-denyconfiguration (deny.toml) and a new CI job to runcargo deny check. - Enforce
RUSTFLAGS="-D warnings"in CI and align workspace crate metadata (license.workspace,publish.workspace,publish = false). - Update dependency constraints and
Cargo.lockto pick up security/advisory-related updates (e.g.,rand,rustls,rustls-webpki).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
deny.toml |
Adds cargo-deny policy (licenses/advisories/bans/sources) including a clarification for spur-proto. |
crates/spur-cloud-common/Cargo.toml |
Inherits workspace license/publish metadata for policy compliance. |
crates/spur-cloud-api/Cargo.toml |
Inherits workspace license/publish metadata for policy compliance. |
Cargo.toml |
Sets workspace publish = false and pins rand minimum to 0.8.6. |
Cargo.lock |
Updates locked dependency graph to newer versions addressing advisories. |
.github/workflows/ci.yml |
Adds a deny job and enforces -D warnings globally in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shiv-tyagi
previously approved these changes
Jun 3, 2026
shiv-tyagi
left a comment
shiv-tyagi
left a comment
Member
There was a problem hiding this comment.
LGTM.
One small thing. Please feel free to address in same PR or a follow up.
Align spur-cloud CI with spur: run cargo deny check, set RUSTFLAGS="-D warnings", and keep clippy --locked with -W clippy::all. Add deny.toml (licenses, sources allow-git for ROCm/spur, bans) and fix license metadata on workspace crates (license/publish inheritance). Clarify Apache-2.0 for git-sourced spur-proto. Update Cargo.lock for RUSTSEC advisories (rand 0.8.6+, rustls-webpki 0.103.13, rustls 0.23.40). Pin spur-proto to ROCm/spur v0.3.0 tag. Resolve Clippy warnings without allow(dead_code) or allow(too_many_arguments): parameter structs for session/Spur client calls, expose DB/API fields, OIDC issuer check, and small lint fixes. Align frontend Session/UserProfile types with the API.
Collaborator
Author
Addressed it. |
shiv-tyagi
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align spur-cloud CI with spur: run cargo deny check, set RUSTFLAGS="-D warnings", and keep clippy --locked with -W clippy::all.
Add deny.toml (licenses, sources allow-git for ROCm/spur, bans) and fix license metadata on workspace crates (license/publish inheritance). Clarify Apache-2.0 for git-sourced spur-proto.
Update Cargo.lock for RUSTSEC advisories (rand 0.8.6+, rustls-webpki 0.103.13, rustls 0.23.40). Pin spur-proto to ROCm/spur v0.3.0 tag.
Resolve Clippy warnings without allow(dead_code) or allow(too_many_arguments): parameter structs for session/Spur client calls, expose DB/API fields, OIDC issuer check, and small lint fixes. Align frontend Session/UserProfile types with the API.