Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a GPU test phase to the Media Libs CI workflow so rocdecode and rocjpeg get exercised using the existing TheRock test orchestration, and updates the TheRock commit pins to a revision that includes those media test configurations.
Changes:
- Bump the pinned
ROCm/TheRockref used by the reusable test workflows to8d1434f5...(2026-03-20). - Update
media-libs-ci.ymlto request testing forrocdecode,rocjpegand add a dependent Linux test job that runs after the build. - Keep the test execution pattern consistent with existing TheRock reusable workflows (
therock-test-packages.yml→therock-test-component.yml).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/therock-test-packages.yml | Updates the pinned TheRock commit used to generate the test matrix and drive package tests. |
| .github/workflows/therock-test-component.yml | Updates the pinned TheRock commit used when running an individual test component. |
| .github/workflows/media-libs-ci.yml | Enables media projects in projects_to_test and adds a post-build GPU test job for rocdecode/rocjpeg. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a test phase to the Media Libs CI to run rocdecode and rocjpeg tests
after a successful build.
Technical Details
New file:
.github/workflows/therock-media-test-packages.ymlA dedicated media test packages workflow, following the same pattern as
therock-rccl-test-packages-single-node.yml. Callstherock-test-component.ymldirectly for rocdecode and rocjpeg, bypassing the generic
therock-test-packages.ymlsanity gate (which requires a full ROCm base install not present in the
media-only build). Both jobs are guarded with
if: ${{ inputs.platform == 'linux' }}since rocdecode and rocjpeg are Linux-only.
.github/workflows/media-libs-ci.ymlAdded
therock-test-linuxjob that runs after the build (needs: [therock-ci-linux])and calls
therock-media-test-packages.ymlwithgfx94X-dcgpuandlinux-mi325-1gpu-ossci-rocm..github/workflows/therock-test-packages.ymlandtherock-test-component.ymlUpdated TheRock pin from
526c77297de1418cbd11edccea09dc37055fd71c(2026-03-12)to
9a38f01d34a90ecabd87d6cdf197466eab4e84ab(2026-03-20), which includesROCm/TheRock#4025 (rocdecode and rocjpeg test scripts and
fetch_test_configurations.pyentries).JIRA ID
NA
Test Plan
linux-mi325-1gpu-ossci-rocm(gfx94X-dcgpu)after a successful media libs build
--rocdecode --tests/--rocjpeg --tests), avoiding dependency on base ROCm artifacts notproduced by the media-only build
Test Result
ALL media tests should pass
Submission Checklist