Skip to content

Media - Test#4355

Open
kiritigowda wants to merge 7 commits intodevelopfrom
users/kiriti/media-test
Open

Media - Test#4355
kiritigowda wants to merge 7 commits intodevelopfrom
users/kiriti/media-test

Conversation

@kiritigowda
Copy link
Contributor

@kiritigowda kiritigowda commented Mar 23, 2026

Motivation

Add a test phase to the Media Libs CI to run rocdecode and rocjpeg tests
after a successful build.

Technical Details

New file: .github/workflows/therock-media-test-packages.yml

A dedicated media test packages workflow, following the same pattern as
therock-rccl-test-packages-single-node.yml. Calls therock-test-component.yml
directly for rocdecode and rocjpeg, bypassing the generic therock-test-packages.yml
sanity gate (which requires a full ROCm base install not present in the
media-only build). Both jobs are guarded with if: ${{ inputs.platform == 'linux' }}
since rocdecode and rocjpeg are Linux-only.

.github/workflows/media-libs-ci.yml

Added therock-test-linux job that runs after the build (needs: [therock-ci-linux])
and calls therock-media-test-packages.yml with gfx94X-dcgpu and
linux-mi325-1gpu-ossci-rocm.

.github/workflows/therock-test-packages.yml and therock-test-component.yml

Updated TheRock pin from 526c77297de1418cbd11edccea09dc37055fd71c (2026-03-12)
to 9a38f01d34a90ecabd87d6cdf197466eab4e84ab (2026-03-20), which includes
ROCm/TheRock#4025 (rocdecode and rocjpeg test scripts and
fetch_test_configurations.py entries).

JIRA ID

NA

Test Plan

  • rocdecode and rocjpeg tests run on linux-mi325-1gpu-ossci-rocm (gfx94X-dcgpu)
    after a successful media libs build
  • Each test fetches only its own artifacts (--rocdecode --tests /
    --rocjpeg --tests), avoiding dependency on base ROCm artifacts not
    produced by the media-only build

Test Result

ALL media tests should pass

Submission Checklist

@kiritigowda kiritigowda self-assigned this Mar 23, 2026
@kiritigowda kiritigowda requested a review from a team as a code owner March 23, 2026 21:00
Copilot AI review requested due to automatic review settings March 23, 2026 21:00
@github-actions github-actions bot added the github actions Pull requests that update GitHub Actions code label Mar 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GPU test phase to the Media Libs CI workflow so rocdecode and rocjpeg get exercised using the existing TheRock test orchestration, and updates the TheRock commit pins to a revision that includes those media test configurations.

Changes:

  • Bump the pinned ROCm/TheRock ref used by the reusable test workflows to 8d1434f5... (2026-03-20).
  • Update media-libs-ci.yml to request testing for rocdecode,rocjpeg and add a dependent Linux test job that runs after the build.
  • Keep the test execution pattern consistent with existing TheRock reusable workflows (therock-test-packages.ymltherock-test-component.yml).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/therock-test-packages.yml Updates the pinned TheRock commit used to generate the test matrix and drive package tests.
.github/workflows/therock-test-component.yml Updates the pinned TheRock commit used when running an individual test component.
.github/workflows/media-libs-ci.yml Enables media projects in projects_to_test and adds a post-build GPU test job for rocdecode/rocjpeg.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kiritigowda
Copy link
Contributor Author

ref: 9a38f01d34a90ecabd87d6cdf197466eab4e84ab # 2026-03-20 - upstream changes include rocdecode updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants