Users/marantic amd/configurable json presets#4331
Draft
marantic-amd wants to merge 11 commits intodevelopfrom
Draft
Users/marantic amd/configurable json presets#4331marantic-amd wants to merge 11 commits intodevelopfrom
marantic-amd wants to merge 11 commits intodevelopfrom
Conversation
…put summary during library finalization.
| * Only sets variables that are not already set in the environment. | ||
| */ | ||
| void | ||
| apply_preset_to_environment(const preset_info& info, bool override_existing = false); |
Contributor
There was a problem hiding this comment.
this can be put in class..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The rocprof-sys-run and rocprof-sys-sample CLI tools require users to manually set dozens of ROCPROFSYS_* environment variables to configure profiling. This is error-prone and has a steep learning curve. Additionally, running --help dumps 100+ options in a flat list, making it difficult to find relevant options.
This PR adds:
--preset=<name>flag--gpu,--rocm,--cpu,--parallel) for composable configurationrocprofiler-systems-bin-commonstatic library to eliminate code duplication between the two toolsTechnical Details
JSON Configuration & Presets
share/rocprofiler-systems/presets/covering general (balanced,detailed,profile-only), GPU (trace-gpu,workload-trace,trace-hw-counters), HPC (trace-hpc,trace-openmp,profile-mpi), and API tracing (sys-trace,runtime-trace) use cases--preset=<name>,--list-presets,--explain=<name>,--export-config[=file]--gpu[=metrics], --rocm[=domains], --cpu[=hz], --parallel[=runtimes]with shorthand expansion (e.g., hip → hip_runtime_api)Shared Library (
rocprofiler-systems-bin-common)Topic-Based Help System
--helpshows a compact summary with quick-start options and a topic index--help=<topic>filters by group: preset, general, tracing, profiling, sampling, process, counters, backend, debug, misc--help=<domain>shows curated cross-group options: gpu, cpu, rocm, parallel--help=allshows full output (previous --help behavior)Pre-Run Validation & Post-Run Summary
JIRA ID
AIPROFSYST-236
AIPROFSYST-238
Test Plan
Test Result
Submission Checklist