[CI] Increase rocDecode and rocJPEG Code Coverage by systems-assistant[bot] · Pull Request #183 · ROCm/rocm-systems

systems-assistant · 2025-08-07T22:41:37Z

PR Details

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

Technical details

Added/updated tests?

Yes
No, Does not apply to this PR.

Updated CHANGELOG?

Yes
No, Does not apply to this PR.

Added/Updated documentation?

Yes
No, Does not apply to this PR.

🔁 Imported from ROCm/rocprofiler-sdk#127
🧑‍💻 Originally authored by @rocm-devops

* swdev-510794 Adding MPI usage with rocprofv3 * update doc * Fixed build issues * updating doc * doc update * Fixed Typos * csv format * change format to shell [ROCm/rocprofiler-sdk commit: 7821657]

* [SWDEV-531379] Fix config Signed-off-by: adapryor <Adam.pryor@amd.com> Change-Id: Ie1bd6903235016a185dd93fbac0a87658fb12a62 * Fix group field find Signed-off-by: adapryor <Adam.pryor@amd.com> Change-Id: I1f8c62615327df4b5ca916b158b4882a3d5a59d0 * fixes Signed-off-by: adapryor <Adam.pryor@amd.com> Change-Id: I971f3e12e293ea9e5d4d67db64d8d7217b87561c --------- Signed-off-by: adapryor <Adam.pryor@amd.com> [ROCm/rdc commit: 8663702]

* SWDEV-460151 - add gfx1201 to amd-staging clr * SWDEV-460151 - removed pal macro --------- Co-authored-by: Jimbo Xie <jiabaxie@amd.com>

* SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests

ammarwa · 2025-08-11T21:05:30Z

Code Coverage Report

Tests Only

Samples Only

Tests + Samples

* SWDEV-460151 - add gfx1201 to amd-staging clr * SWDEV-460151 - removed pal macro --------- Co-authored-by: Jimbo Xie <jiabaxie@amd.com> [ROCm/clr commit: a5d932f]

* SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests [ROCm/hip-tests commit: d6f415c]

* SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests

bgopesh · 2025-09-03T11:37:07Z

As soon as PSDB passes, I will merge this, as it was asked why rocprofiler-sdk code coverage went down.

…to enable tests

…ue is resolved

bgopesh · 2025-09-03T13:50:02Z

RHEL9 passed in PSDB. merging this now.

* Increase rocDecode code coverage and add version check * Update rocJPEG tests * Fix rocJPEG tests * Enable building tests/samples in rocm release compat workflow * Readded rocJPEG test skips * formatting * Adding ROCm libraries for the code-coverage job * Added return value check for error message and updated compatability to enable tests * Disable rocm_release_compatibility samples and tests until openmp issue is resolved [rocm-systems] ROCm/rocm-systems#183 (commit 2cfedef)

* API support for enabling rocshmem bitcode integration * move implementation to along with host side APIs

This reverts commit 1053827.

* API support for enabling rocshmem bitcode integration * move implementation to along with host side APIs [ROCm/rocshmem commit: 1053827]

This reverts commit 31804fc. [ROCm/rocshmem commit: a66f782]

…s-develop-636 Merger auto-merge-rocm-systems-develop-636 into amd-npi-compute-external-merge-new-636

If hipFile is used as a subproject in another project, `CMAKE_SOURCE_DIR` will point to the root of *that* project instead of ours, which could break the build. These changes use alternative paths to address this. Part of AIHIPFILE-129

If hipFile is used as a subproject in another project, `CMAKE_SOURCE_DIR` will point to the root of *that* project instead of ours, which could break the build. These changes use alternative paths to address this. Part of AIHIPFILE-129 [ROCm/hipFile commit: 370110a]

…7618) ## Motivation  This is the improved other half of #6116 `ROCPROFSYS_TRACE_LEGACY` encodes information that is missing from debug args when trace cache is used. For example, with `pthread_create`, we currently see: <img width="764" height="105" alt="image" src="https://github.com/user-attachments/assets/5b21f817-565f-4628-b546-787d3c51c3a2" /> But with `ROCPROFSYS_TRACE_LEGACY=ON`, we see: <img width="766" height="198" alt="image" src="https://github.com/user-attachments/assets/b591831e-c867-475c-ac44-908ae9588495" /> There is a clear disconnect. ## Technical Details  `category_region.hpp` Cache gotcha/perfetto region arguments into the trace cache. Category-independent helpers now live in a policy-templated helper `rocprofsys::utility::category_region<Policy>`, composed by `category_region<CategoryT>` via using `region_cache = utility::category_region<>`. The cache lifecycle's system seams (clock, trace-cache sink, thread metadata) are injected as value members through a Policy bundle - `serialize_name_value_pairs`: serializes the gotcha {"name", value} pairs into the wire format (idx;;type;;name;;value;;). - `serialize_annotation_args / serialize_return_arg`: serialize gotcha audit arguments (synthesized arg{N}-{type} names) and return values. - `has_trace_cache_arg_pairs_v`: detects the gotcha pair convention (even count, string-like name slots). - `next_arg_index`: derives the next index from the last record instead of storing a count. - `renumber_serialized_args`: renumbers an appended batch in a single string pass. - The above are static helpers; the stateful cache lifecycle (`cache_start` / `cache_stop` / `append_cache_args` / `flush_pending_cached_entries`) are instance methods reached through a per-thread `instance()`. - `append_cache_args`: appends a batch to the open entry (adopts the first batch as-is, else renumbers). - `start / start_with_args` now funnel through one start_impl. - Hooked gotcha audit incoming/outgoing paths to cache argument and return values. `regions.cpp`: - Adjust `flush` call signature. Added unit tests Added pytests - two new binaries: `annotations.cpp` and `pthread.cpp`. The first tests perfetto annotations and the second verifies that gotcha arguments are captured. - Both ROCpd and perfetto outputs are verified. **OTHER** `test_shmem_gotcha.cpp`: Drop `name` and `[this]`. It was causing workflow to fail: https://github.com/ROCm/rocm-systems/actions/runs/27972186388/job/82780906185 ## JIRA ID   Jira ID : AIPROFSYST-519 ## Test Plan New unit tests New pytests: ``` minimal-pthreads-binary-rewrite minimal-pthreads-runtime-instrument minimal-pthreads-sys-run ```  ## Test Result Unit tests pass: ``` Note: Google Test filter = category_region* [==========] Running 29 tests from 3 test suites. ... [----------] Global test environment tear-down [==========] 38 tests from 4 test suites ran. (0 ms total) [ PASSED ] 38 tests. ``` New pytests pass: ``` Start 182: minimal-pthreads-binary-rewrite 2/5 Test #182: minimal-pthreads-binary-rewrite ....... Passed 5.19 sec Start 183: minimal-pthreads-runtime-instrument 3/5 Test #183: minimal-pthreads-runtime-instrument ... Passed 6.69 sec Start 184: minimal-pthreads-sys-run 4/5 Test #184: minimal-pthreads-sys-run .............. Passed 2.14 sec ``` For `pthreads`: <img width="817" height="209" alt="image" src="https://github.com/user-attachments/assets/fa1330b8-aab7-4141-bb85-96d789da1f6e" />  ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: David Galiffi <David.Galiffi@amd.com>

systems-assistant Bot added the imported pr label Aug 7, 2025

systems-assistant Bot requested review from jrmadsen and t-tye as code owners August 7, 2025 22:41

systems-assistant Bot added the project: rocprofiler-sdk label Aug 7, 2025

amd-hsivasun added ias-review ready for 2nd review labels Aug 7, 2025

jayhawk-commits assigned itrowbri Aug 8, 2025

jayhawk-commits added the organization: ROCm label Aug 8, 2025

xuchen-amd pushed a commit that referenced this pull request Aug 10, 2025

SWDEV-460151 - add gfx1201 to amd-staging clr (#183)

a5d932f

* SWDEV-460151 - add gfx1201 to amd-staging clr * SWDEV-460151 - removed pal macro --------- Co-authored-by: Jimbo Xie <jiabaxie@amd.com>

xuchen-amd pushed a commit that referenced this pull request Aug 10, 2025

SWDEV-528351 - Adds hipTexRefSetGet* tests (#183)

d6f415c

* SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests

itrowbri force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch from 5133cae to cbb613f Compare August 11, 2025 20:40

venkat1361 self-requested a review August 12, 2025 15:54

venkat1361 approved these changes Aug 12, 2025

View reviewed changes

itrowbri assigned jrmadsen Aug 12, 2025

jrmadsen force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch from cbb613f to c2fd6b3 Compare August 18, 2025 15:55

github-actions Bot added the github actions Pull requests that update GitHub Actions code label Aug 18, 2025

itrowbri force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch from c2fd6b3 to 386ef6e Compare August 18, 2025 17:59

itrowbri force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch from 386ef6e to 10d026f Compare August 19, 2025 15:37

itrowbri requested a review from a team as a code owner August 19, 2025 15:37

itrowbri force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch from 10d026f to 5cd9dbc Compare August 19, 2025 16:23

systems-assistant Bot pushed a commit that referenced this pull request Aug 19, 2025

SWDEV-528351 - Adds hipTexRefSetGet* tests (#183)

2de6d74

* SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests * SWDEV-528351 - Adds hipTexRefSetGet* tests

itrowbri force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch 2 times, most recently from 985e39b to 62c1729 Compare August 21, 2025 15:12

jrmadsen approved these changes Aug 21, 2025

View reviewed changes

itrowbri force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch from 62c1729 to 0458183 Compare August 26, 2025 14:22

jrmadsen added the ready to merge label Aug 26, 2025

bwelton force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch from 0458183 to 8a20435 Compare September 2, 2025 15:46

itrowbri force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch from 8a20435 to d534dff Compare September 2, 2025 20:03

bgopesh force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch from d534dff to 9fc1262 Compare September 3, 2025 11:12

itrowbri and others added 9 commits September 3, 2025 19:19

Increase rocDecode code coverage and add version check

4882f9a

Update rocJPEG tests

e4d1b67

Fix rocJPEG tests

6ea33b8

Enable building tests/samples in rocm release compat workflow

06713ad

Readded rocJPEG test skips

ab26727

formatting

94d98c6

Adding ROCm libraries for the code-coverage job

3e3ba6a

Added return value check for error message and updated compatability …

4649762

…to enable tests

Disable rocm_release_compatibility samples and tests until openmp iss…

fd6484e

…ue is resolved

bgopesh force-pushed the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch from 9fc1262 to fd6484e Compare September 3, 2025 13:49

bgopesh merged commit 2cfedef into develop Sep 3, 2025
22 of 31 checks passed

bgopesh deleted the import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage branch September 3, 2025 13:50

SrirakshaNag added ready for peer review ready for 2nd review labels Sep 9, 2025

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Add host API to query Device side context detail (#183)

1053827

* API support for enabling rocshmem bitcode integration * move implementation to along with host side APIs

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Revert "Add host API to query Device side context detail (#183)" (#196)

a66f782

This reverts commit 1053827.

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Add host API to query Device side context detail (#183)

31804fc

* API support for enabling rocshmem bitcode integration * move implementation to along with host side APIs [ROCm/rocshmem commit: 1053827]

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Revert "Add host API to query Device side context detail (#183)" (#196)

f38ffbf

This reverts commit 31804fc. [ROCm/rocshmem commit: a66f782]

dayatsin-amd pushed a commit that referenced this pull request Apr 7, 2026

Merge pull request #183 from AMD-ROCm-Internal/auto-merge-rocm-system…

3d08757

…s-develop-636 Merger auto-merge-rocm-systems-develop-636 into amd-npi-compute-external-merge-new-636

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CI] Increase rocDecode and rocJPEG Code Coverage#183

[CI] Increase rocDecode and rocJPEG Code Coverage#183
bgopesh merged 9 commits into
developfrom
import/develop/ROCm_rocprofiler-sdk/itrowbri_rocdecode-rocjpeg-test-coverage

systems-assistant Bot commented Aug 7, 2025

Uh oh!

ammarwa commented Aug 11, 2025 •

edited

Loading

Code Coverage Report

Code Coverage Report

Tests Only

Samples Only

Tests + Samples

Uh oh!

bgopesh commented Sep 3, 2025

Uh oh!

bgopesh commented Sep 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

systems-assistant Bot commented Aug 7, 2025

PR Details

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

Technical details

Added/updated tests?

Updated CHANGELOG?

Added/Updated documentation?

Uh oh!

ammarwa commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Report

Code Coverage Report

Tests Only

Samples Only

Tests + Samples

Uh oh!

bgopesh commented Sep 3, 2025

Uh oh!

bgopesh commented Sep 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ammarwa commented Aug 11, 2025 •

edited

Loading