Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ AMD provides prerelease ROCm packages for both Debian-based and RPM-based Linux
Repository base URL:

```
https://rocm.prereleases.amd.com/packages/
https://rocm.prereleases.amd.com/packages-multi-arch/
```

---
Expand All @@ -119,7 +119,7 @@ Replace `<os_profile>` with the appropriate distribution profile

```bash
sudo tee /etc/apt/sources.list.d/rocm.list << EOF
deb [arch=amd64 signed-by=/etc/apt/keyrings/amdrocm.gpg] https://rocm.prereleases.amd.com/packages/<os_profile> stable main
deb [arch=amd64 signed-by=/etc/apt/keyrings/amdrocm.gpg] https://rocm.prereleases.amd.com/packages-multi-arch/<os_profile> stable main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of os_profile, lets give either ubuntu2404 or ubuntu2604 so that just copy paste works and in comments can ask user to change according to their OS

EOF
sudo apt update
```
Expand All @@ -129,7 +129,7 @@ sudo apt update
###### Install ROCm

```bash
sudo apt install amdrocm-gfx94x # Change the gfx arch based on your machine.
sudo apt install amdrocm7.14-gfx942 # Change the version (7.14) and gfx arch (gfx942) based on your release and machine.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let keep this as amdrocm(runtime alone) or even better amdrocm-core-sdk(full ROCm core)
So that we dont have to change based on version and gfx arch.
Can put in comment how to install arch specific packages

```

---
Expand All @@ -145,7 +145,7 @@ Replace `<os_profile>` with the appropriate distribution profile
sudo tee /etc/yum.repos.d/rocm.repo << EOF
[rocm]
name=ROCm Prerelease Repository
baseurl=https://rocm.prereleases.amd.com/packages/<os_profile>/x86_64/
baseurl=https://rocm.prereleases.amd.com/packages-multi-arch/<os_profile>/x86_64/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of os_profile, lets give either rhel10 so that just copy paste works and in comments can ask user to change according to their OS

enabled=1
gpgcheck=1
gpgkey=https://rocm.prereleases.amd.com/packages/gpg/rocm.gpg
Expand All @@ -158,5 +158,5 @@ sudo dnf clean all
###### Install ROCm

```bash
sudo dnf install amdrocm-gfx94x # Change the gfx arch based on your machine.
sudo dnf install amdrocm7.14-gfx942 # Change the version (7.14) and gfx arch (gfx942) based on your release and machine.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let keep this as amdrocm(runtime alone) or even better amdrocm-core-sdk(full ROCm core)
So that we dont have to change based on version and gfx arch.
Can put in comment how to install arch specific packages

```
Loading