[CI] Parity: include PR head SHA in run name for PR-triggered runs#3389
Open
ethanwee1 wants to merge 1 commit into
Open
[CI] Parity: include PR head SHA in run name for PR-triggered runs#3389ethanwee1 wants to merge 1 commit into
ethanwee1 wants to merge 1 commit into
Conversation
ethanwee1
requested review from
jataylo,
jeffdaily,
jithunnair-amd and
pruthvistony
as code owners
run-name is evaluated once when the run starts, so it cannot include the commit SHA that download_testlogs resolves later from --pr_id. For PR-triggered runs, resolve the PR head SHA in setup-matrix and PATCH the run name via the REST API so it reads "PR <id> . <sha> . <archs>". The PR->SHA lookup is intentionally duplicated here (download_testlogs keeps get_latest_commit_sha so the script can still run standalone with just --pr_id). Adds actions:write to the setup-matrix job for the PATCH.
ethanwee1
force-pushed
the
ethanwee/parity-pr-runname-sha
branch
from
b4abdec to
8ddc477
Compare
|
Jenkins build for 8ddc477e7a3d750f828cdc1f7468b2f054aa626e commit finished as FAILURE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR-triggered parity runs currently show only
PR <id> · <archs>in the Actions run list (e.g. this run readsPR 187011 · mi200), which makes it hard to tell which upstream commit was actually tested. This adds the resolved PR head SHA so the run name reads:How
run-nameis evaluated once when the run starts and can only read theinputs/githubcontexts, so it cannot include the SHA thatdownload_testlogsresolves later from--pr_id. Instead,setup-matrixnow resolves the PR head SHA (repos/pytorch/pytorch/pulls/<id>) and PATCHes the run name via the REST API (PATCH /repos/{owner}/{repo}/actions/runs/{run_id}).inputs.pr_idset, nobaseline_sha/csv_name); other run names are unchanged.pr_id → shalookup is intentionally duplicated here —download_testlogskeeps its ownget_latest_commit_shaso it can still be run standalone with just--pr_id.actions: writeto thesetup-matrixjob (required for the run-name PATCH).Test plan
PR <id> · <sha> · <archs>shortly after start.