[release/2.12] Fix Windows cross-drive HIPIFY failure in CUDAExtension#3383
Closed
ethanwee1 wants to merge 1 commit into
Closed
[release/2.12] Fix Windows cross-drive HIPIFY failure in CUDAExtension#3383ethanwee1 wants to merge 1 commit into
ethanwee1 wants to merge 1 commit into
Conversation
When building HIP extensions (e.g. torchaudio) on Windows where the source checkout lives on a subst/virtual drive (B:) that aliases a directory on the real drive (C:), os.path.relpath() raised "path is on mount 'C:', start on mount 'B:'" because os.getcwd() reported the alias while the hipified source resolved to the underlying drive. Normalize both the build dir and the hipified source through os.path.realpath() before computing the relative path.
Author
|
Consolidated into #3382 so the pin and the Windows HIPIFY fix can be tested together in one build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://amd-hub.atlassian.net/browse/ROCM-24803?focusedCommentId=500051