Skip to content

[release/2.12_gfx1250] Support for gfx1250 - bug fixes #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pragupta merged 4 commits into from
Jun 17, 2026
Merged

[release/2.12_gfx1250] Support for gfx1250 - bug fixes #3330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
257d563
UCX_COMMIT and UCC_COMMIT are not required. Enable USE_FBGEMM.
rraminen Jun 17, 2026
432993f
These files are not used, so changes to these are not needed
rraminen Jun 17, 2026
5be40b8
Turn USE_FBGEMM ON
rraminen Jun 17, 2026
6ce5210
pandas is not required in requirements.txt
rraminen Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .ci/docker/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,6 @@ case "$tag" in
ROCM_VERSION=7.2
TRITON=yes
KATEX=yes
UCX_COMMIT=${_UCX_COMMIT}
UCC_COMMIT=${_UCC_COMMIT}
PYTORCH_ROCM_ARCH="gfx90a;gfx942;gfx950;gfx1100;gfx1250"
if [[ $tag =~ "benchmarks" ]]; then
INDUCTOR_BENCHMARKS=yes
Expand Down
2 changes: 1 addition & 1 deletion .ci/pytorch/binary_populate_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export PYTORCH_EXTRA_INSTALL_REQUIREMENTS="${PYTORCH_EXTRA_INSTALL_REQUIREMENTS:
# TODO: We don't need this anymore IIUC
export TORCH_PACKAGE_NAME='torch'

export USE_FBGEMM=0
export USE_FBGEMM=1
export PIP_UPLOAD_FOLDER="$PIP_UPLOAD_FOLDER"
export DOCKER_IMAGE="$DOCKER_IMAGE"

Expand Down
4 changes: 0 additions & 4 deletions .github/actionlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,9 @@ self-hosted-runner:
# gfx942 runners
- linux.rocm.gpu.gfx942.1
- linux.rocm.gpu.gfx942.4
- linux.rocm.gfx942.docker-cache
# gfx950 runners
- linux.rocm.gpu.gfx950.1
- linux.rocm.gpu.gfx950.4
# gfx1250 runners
- linux.rocm.gpu.gfx1250.1
- linux.rocm.gpu.gfx1250.4
# Org wise AWS `mac2.metal` runners (2020 Mac mini hardware powered by Apple silicon M1 processors)
- macos-m1-stable
- macos-m1-14
Expand Down
77 changes: 0 additions & 77 deletions .github/workflows/inductor-rocm-gfx1250.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ cmake_dependent_option(USE_CUSPARSELT "Use cuSPARSELt" ON "USE_CUDA" OFF)
cmake_dependent_option(USE_CUDSS "Use cuDSS" ON "USE_CUDA" OFF)
# USE_ROCM is guarded against in Dependencies.cmake because USE_ROCM is not properly defined here
cmake_dependent_option(USE_CUFILE "Use cuFile" ON "USE_CUDA AND NOT WIN32" OFF)
option(USE_FBGEMM "Use FBGEMM (quantized 8-bit server operators)" OFF)
option(USE_FBGEMM "Use FBGEMM (quantized 8-bit server operators)" ON)
option(USE_KINETO "Use Kineto profiling library" ON)
option(USE_CUPTI_SO "Use CUPTI as a shared library" ON)
option(USE_GFLAGS "Use GFLAGS" OFF)
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ lintrunner==0.12.11 ; platform_machine != "s390x"
networkx==2.8.8
optree==0.13.0 ; python_version < "3.14"
optree==0.17.0 ; python_version >= "3.14"
pandas
psutil==7.2.2
spin==0.17
sympy==1.13.3
Expand Down