[AMDGPU] __fp16 -> _Float16 and _Vector -> _ExtVector#1759
Open
jhuber6 wants to merge 1 commit intoROCm:amd-stagingfrom
Open
[AMDGPU] __fp16 -> _Float16 and _Vector -> _ExtVector#1759jhuber6 wants to merge 1 commit intoROCm:amd-stagingfrom
jhuber6 wants to merge 1 commit intoROCm:amd-stagingfrom
Conversation
Summary: Truthfully, I wonder if we shouldn't be able to convert `__fp16` to `_Float16` implicitly. Otherwise, these will likely be a bit more breaking than we might expect, as OpenCL's `half` keys to `__fp16`. The ext vector changes should be harmless though as those are the native vectors for OpenCL and the same in 99.9% of the cases.
Collaborator
ronlieb
reviewed
Mar 15, 2026
Collaborator
ronlieb
left a comment
ronlieb
left a comment
There was a problem hiding this comment.
resubmit this as a PR directly to amd-staging and it will get a rockCI which includes a build of CK
Forks are not launching the rockCI at present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Truthfully, I wonder if we shouldn't be able to convert
__fp16to_Float16implicitly. Otherwise, these will likely be a bit morebreaking than we might expect, as OpenCL's
halfkeys to__fp16. Theext vector changes should be harmless though as those are the native
vectors for OpenCL and the same in 99.9% of the cases.