Add CI workflow to run unit tests on PRs#196
Open
bhatnitish wants to merge 6 commits into
Open
Conversation
spraveenio
requested changes
Jun 17, 2026
The previous commit changed GetAMDGPUs to Warning+return instead of Fatal when the driver is absent. This broke production behavior where we want the process to exit immediately on hardware nodes without the driver. Instead, add a FatalOnDriverUnavailable package variable (defaults to true) that tests disable via TestMain, keeping production Fatal behavior intact while letting CI run tests without GPUs.
Add workflow_dispatch trigger to allow manual runs, and a concurrency group with cancel-in-progress to cancel stale runs when new commits are pushed to the same PR. Mirrors ROCm/device-config-manager#32.
…n_id change Commit e8120e3 changed GetDevIdsFromTopology from using unique_id (hashed numeric strings) to using domain/location_id (PCI addresses), but the test expectations were not updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/unit-tests.yml) that runsgo test ./...on every pull request targetingmasteror anyrelease-*branch.actions/setup-go@v5with the Go version pinned togo.modto keep CI aligned with the project's declared toolchain.Test plan
masteror arelease-*branch and confirm the Unit Tests check appears and passes.