Skip to content

ci: deselect PGLE/FDO profiling tests on ROCm (ROCM-25581) #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srinivamd wants to merge 1 commit into
base: rocm-jaxlib-v0.9.1
Choose a base branch
from
Open

ci: deselect PGLE/FDO profiling tests on ROCm (ROCM-25581) #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ci/run_pytest_rocm.sh
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,12 @@ set +e
--deselect=tests/multi_device_test.py::MultiDeviceTest::test_computation_follows_data \
--deselect=tests/multiprocess_gpu_test.py::MultiProcessGpuTest::test_distributed_jax_visible_devices \
--deselect=tests/compilation_cache_test.py::CompilationCacheTest::test_task_using_cache_metric \
--deselect=tests/pgle_test.py::PgleTest::testAutoPgle \
--deselect=tests/pgle_test.py::PgleTest::testAutoPgleWithCommandBuffers0 \
--deselect=tests/pgle_test.py::PgleTest::testAutoPgleWithCommandBuffers1 \
--deselect=tests/pgle_test.py::PgleTest::testAutoPgleWithPersistentCache \
--deselect=tests/pgle_test.py::PgleTest::testPGLEProfilerGetFDOProfile \
tests

first_cmd_retval=$?

if [[ $gpu_count -gt 1 ]]; then
# Run multi-accelerator tests across all GPUs without xdist.
unset JAX_ENABLE_ROCM_XDIST

"$JAXCI_PYTHON" -m pytest --tb=short \
Expand All @@ -147,12 +147,12 @@ if [[ $gpu_count -gt 1 ]]; then
--deselect=tests/multi_device_test.py::MultiDeviceTest::test_computation_follows_data \
--deselect=tests/multiprocess_gpu_test.py::MultiProcessGpuTest::test_distributed_jax_visible_devices \
--deselect=tests/compilation_cache_test.py::CompilationCacheTest::test_task_using_cache_metric \
--deselect=tests/pgle_test.py::PgleTest::testAutoPgle \
--deselect=tests/pgle_test.py::PgleTest::testAutoPgleWithCommandBuffers0 \
--deselect=tests/pgle_test.py::PgleTest::testAutoPgleWithCommandBuffers1 \
--deselect=tests/pgle_test.py::PgleTest::testAutoPgleWithPersistentCache \
--deselect=tests/pgle_test.py::PgleTest::testPGLEProfilerGetFDOProfile \
tests

second_cmd_retval=$?
else
echo "Skipping multi-accelerator tests (only $gpu_count GPU detected)"
second_cmd_retval=0
fi

# Exit with failure if either command fails.
Expand Down