[ROCm] Skip TF32 dot algorithm tests on Navi/RDNA GPUs#783
Open
srinivamd wants to merge 1 commit into
Open
Conversation
TF32 (TensorFloat-32) is only supported on CDNA GPUs (MI100+/gfx9) via MFMA instructions. RDNA GPUs (Navi/Radeon) lack this hardware. Upstream PR jax-ml#34534 changed the skip guard from unconditional to CUDA-only, which correctly enables TF32 tests on CDNA but also unblocks them on RDNA where XLA raises UNIMPLEMENTED. Cherry-pick the Navi/RDNA TF32 skip from rocm-jaxlib-v0.8.2 to skip TF32_TF32_F32 and TF32_TF32_F32_X3 on Radeon devices. Fixes: ROCM-25363
magaonka-amd
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick the Navi/RDNA TF32 skip guard from
rocm-jaxlib-v0.8.2torocm-jaxlib-v0.9.1.TF32_TF32_F32andTF32_TF32_F32_X3dot algorithm tests on Radeon/RDNA GPUsRoot Cause
Upstream PR jax-ml/jax#34534 (merged 2026-02-11 by
magaonka-amd) changed the TF32 skip logic from:to:
This correctly enables TF32 tests on ROCm CDNA GPUs (MI100+) but also unblocks them on RDNA GPUs (Navi/Radeon) where XLA's
gfx9_mi100_or_later()gate correctly returnsUNIMPLEMENTED.The
rocm-jaxlib-v0.8.2branch had a supplementary skip block (via ROCm/jax#635) that checked"Radeon" in device_kindto skip TF32 on RDNA GPUs. This was never upstreamed or cherry-picked to v0.9.1.Test plan
tests/lax_test.py::LaxTest::testDotAlgorithm13on Navi4x/gfx1201 — should now be SKIPPED instead of FAILEDtestDotAlgorithmsuite on MI300X/gfx942 — TF32 tests should still PASStestDotAlgorithmsuite on Navi4x — non-TF32 tests should still pass, TF32 variants skippedFixes: ROCM-25363