Use make_shared to create a shared pointer#184
Closed
jbelloncastro wants to merge 1 commit intodevelopfrom
Closed
Conversation
jbelloncastro
requested review from
derobins,
gaoikawa,
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
Constructing a `shared_ptr` instance with `make_shared` is simpler and more efficient than using the raw pointer constructor. Shared pointers need extra storage for the atomic reference count. `make_shared` has the opportunity to reserve the memory for both ref-count and the object itself in one operation, while the alternative requires two separate allocations, with the ref-count storage requiring an extra indirection to object itself.
jbelloncastro
force-pushed
the
jbelloncastro-patch-1
branch
from
79b13fc to
d798723
Compare
Collaborator
|
Hi @jbelloncastro. Thanks for having a look at improving hipFile. I agree that make_shared is better in general, but in this case we override new to allocate pinned host memory. make_shared will call the default allocator, which will not give us the allocation type we want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Small code simplification.
Technical Details
Constructing a
shared_ptrinstance withmake_sharedis simpler and more efficient than using the raw pointer constructor.Shared pointers need extra storage for the atomic reference count.
make_sharedhas the opportunity to reserve the memory for both ref-count and the object itself in one operation, while the alternative requires two separate allocations, with the ref-count storage requiring an extra indirection to object itself.Test Plan
The change has no effect on functionality so all the tests should have the same outcome.
Test Result
N/A
Submission Checklist