Conversation
derobins
requested review from
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
There was a problem hiding this comment.
Pull request overview
Updates CMake path references to work correctly when this repository is included as a subproject, avoiding accidental resolution to a parent project’s root.
Changes:
- Replaced
CMAKE_SOURCE_DIRwithPROJECT_SOURCE_DIRacross several CMake modules. - Updated module path and various file/directory references (coverage include, headers, examples, docs input, shared includes, license path).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| cmake/AISUseGTest.cmake | Updates coverage include file path to use project root. |
| cmake/AISInstall.cmake | Installs headers/examples and sets CPack license path from project root. |
| cmake/AISDocumentation.cmake | Points Doxygen input at the project’s include directory. |
| cmake/AISAddLibraries.cmake | Uses project root for adding the shared include directory. |
| cmake/AISAddExecutable.cmake | Uses project root for adding the shared include directory. |
| CMakeLists.txt | Sets CMAKE_MODULE_PATH relative to the project root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
derobins
changed the title
CMAKE_SOURCE_DIR
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
derobins
force-pushed
the
derobins/project_source_dir
branch
from
6922745 to
3c241a7
Compare
If hipFile is used as a subproject in another project, `CMAKE_SOURCE_DIR` will point to the root of *that* project instead of ours. `PROJECT_SOURCE_DIR` will point to *our* project root, which is the root of the repo.
derobins
force-pushed
the
derobins/project_source_dir
branch
from
3c241a7 to
041f49c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
If hipFile is used as a subproject in another project,
CMAKE_SOURCE_DIRwill point to the root of that project instead of ours, which could break the build. These changes use alternative paths to address this.Part of AIHIPFILE-129