Skip to content

Conversation

@shumway
Copy link
Collaborator

@shumway shumway commented Jan 14, 2026

This is mostly adjustments to enum values so that the docs align correctly with the current code.

Also updated the calendar scope of the project to extend through March 2026.

Note: These README.md files are just internal code documentation for developers, and not part of the public documentation of CK.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates internal README documentation to align with recent code changes in the CK Builder experimental feature. The primary changes involve correcting enum value references and updating project metadata.

Changes:

  • Updated ElementwiseOperation enum references from the non-existent NONE to the correct PASS_THROUGH value
  • Clarified documentation for signature-level fields (data_type and elementwise_operation)
  • Extended project timeline from "October - December 2025" to "October 2025 - March 2026"

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
experimental/builder/include/ck_tile/builder/testing/README.md Fixed 4 instances of incorrect ElementwiseOperation::NONE to PASS_THROUGH in code examples
experimental/builder/include/ck_tile/builder/README.md Updated field descriptions for data_type and elementwise_operation, added documentation for special layout values and bias tensor layouts
experimental/builder/README.md Extended project development timeline to March 2026 and corrected "CKTile" to "CK Tile"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shumway
Copy link
Collaborator Author

shumway commented Jan 15, 2026

I don't understand why there was a copilot review and now other changes are being merged into this PR. It just updates some of our README.md files for the CK Builder, and now it's triggering CI on GPUs (wasting our CI resources for no reason). I just killed the CI, that shouldn't be run on documentation PRs, and there was no to add a commit to this PR.

This is mostly adjustments to enum values so that the docs align correctly with the current code.

Also updated the calendar scope of the project to extend through March 2026.
@shumway shumway force-pushed the jshumway/builder-readme branch from c71ad10 to df7ee27 Compare January 15, 2026 07:15
@shumway shumway changed the title Update README.md files to match recent code changes [CK_BUILDER] Update README.md files to match recent code changes Jan 15, 2026
@shumway
Copy link
Collaborator Author

shumway commented Jan 15, 2026

I just cleaned this PR up again, undoing the merge from develop and resetting to just a README file update. This should not run CI.

@shumway shumway merged commit 644cdbe into develop Jan 16, 2026
6 checks passed
@shumway shumway deleted the jshumway/builder-readme branch January 16, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants