Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Triton/Gloun paged-attention decode kernel to handle a couple of edge cases around multi-token-per-program (MTP) indexing and per-token KV scale staging.
Changes:
- Fixes
query_token_idxcomputation forQUERY_SEQ_LEN_POW2 > 1to avoid double-counting themtp_idxoffset aftermax_logits_base_offsetsis expanded into the flattened query-group space. - Removes a later redundant/incorrect recomputation of
query_token_idxbased on the already-expandedmax_logits_base_offsets. - Ensures per-token KV scales are reshaped to a 1D
[CONTEXT_PARTITION_SIZE]buffer before staging into shared memory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist