Open
Conversation
It is incorrect to pass AK1Value = BK1Value = 8 to work around static asserts triggered in thread transfers for some configs. Preshuffling (shuffle_weight) uses KPack = 16 for FP8, so BK1 must be the same otherwise the kernel loads wrong values. Instead other parameters should be decreased in such cases: * A/BBlockTransferThreadClusterLengths... so not all threads participate in loading (this commit) * or A/BBlockTransferSrcScalarPerVector... so each thread load less data.
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix for AICK-1084: FP8 2stages CK MoE produces incorrect results for intermediate dim < 256
Technical Details
It is incorrect to pass AK1Value = BK1Value = 8 to work around static asserts triggered in thread transfers for some configs.
Preshuffling (shuffle_weight) uses KPack = 16 for FP8, so BK1 must be the same otherwise the kernel loads wrong values.
Instead other parameters should be decreased in such cases:
Test Plan
Test Result
Submission Checklist