[Bug] Default value of ChunkQ in deepgemm could lead to divided_by_0 error #2891
Open
[Bug] Default value of ChunkQ in deepgemm could lead to divided_by_0 error #2891
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a divide-by-zero failure in the DeepGEMM FP8 paged MQA logits Triton wrapper that can occur when the default ChunkQ is larger than heads, causing TileQCount to become 0 and breaking the Triton grid/SplitKV computation.
Changes:
- Clamp
ChunkQtoheadsindeepgemm_fp8_paged_mqa_logits_stage1to preventTileQCount == 0. - Prevent downstream
TotalCuCount // TileQCountfrom raising aZeroDivisionErrorin the reported configuration (e.g., heads=32, ChunkQ=64).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update TileQCount calculation in deepgemm_fp8_paged_mqa_logits_stage1 to avoid possible divided_by_zero issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLM 5.1 FP8 fails on MI300/355 because its index_n_heads=32 and ChunkQ = 64, which will lead to divided by zero error when calculation triton grid.