Skip to content

dsv3 blockscale gemm config in mi300#2881

Open
yzhou103 wants to merge 2 commits intomainfrom
add_dsv3_mi300_blockscale_config
Open

dsv3 blockscale gemm config in mi300#2881
yzhou103 wants to merge 2 commits intomainfrom
add_dsv3_mi300_blockscale_config

Conversation

@yzhou103
Copy link
Copy Markdown
Contributor

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@yzhou103 yzhou103 requested review from a team and Copilot April 23, 2026 10:28
@github-actions
Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:sglang SGLang integration tests
ci:atom ATOM benchmark (DeepSeek-R1 + GPT-OSS)
ci:vllm vLLM benchmark
ci:all All of the above

Add labels via the sidebar or gh pr edit 2881 --add-label <label>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds additional GEMM (M,N,K) problem sizes to the DeepSpeed v3 a8w8 blockscale “untuned” config, likely to cover MI300-relevant shapes and smaller-M cases.

Changes:

  • Extends the CSV with many new (M,N,K) entries (notably N=512, K=7168 with M ranging 1→32768).
  • Adds a blank separator line and one additional shape that differs from the new block’s (N,K) pattern.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

20480, 7168, 2048
32768, 7168, 2048 No newline at end of file
32768, 7168, 2048

Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an empty row in the CSV. If the loader expects every non-header line to contain exactly 3 comma-separated values, this blank line can cause parse failures or require special-casing. Remove the blank line, or replace it with a comment row only if the parser explicitly supports comments.

Suggested change

Copilot uses AI. Check for mistakes.

1, 512, 7168
2, 512, 7168
4, 7168, 2048
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new block largely follows a consistent pattern of N=512, K=7168 while sweeping M, but the entry 4, 7168, 2048 breaks that pattern (N/K appear swapped vs surrounding rows). If this isn’t intentional, it’s likely a typo and should be corrected to match the intended N/K values; if it is intentional, consider grouping it with other *, 7168, 2048 shapes (or adding a clear separator/comment if supported) to avoid accidental misconfiguration.

Suggested change
4, 7168, 2048
4, 512, 7168

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants