Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In sglang PR#23562, we bump the nsa indexer's
page_sizeto 64, which switches the indexer attention path to the_gluon_deepgemm_fp8_paged_mqa_logits_preshufflekernel. The kernel consumes the indexer k cache in an MFMA 16×16 preshuffled layout.Technical Details
This PR extends
indexer_k_quant_and_cacheandcp_gather_indexer_k_quant_cacheto support writing and gathering the preshuffled layout.We add an optional
preshuffle: bool = Falseargument to both ops. Default isFalse, so existing callers are unaffected.preshuffle=False(default): unchanged row-major[block_size, head_dim]layout inside each paged block.preshuffle=True: each block's k region is written / read as a sequence of MFMA 16×16 tiles.Also extend the testcase with
-p/--preshuffleflag.Test Plan
Test Result
Submission Checklist