fix(jax): skip JAX wheel builds/tests on ASan builds#6213
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
|
@geomin12 , can you please let me know how to test this from ASAN side? |
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
The asan release workflows have deeper issues than just this. Let's disable the nightly/scheduled release jobs before trying to patch like this.
| trigger_release_jax_wheels: | ||
| needs: [build_artifacts, build_tarballs, build_python_packages] | ||
| name: Trigger Release JAX Wheels | ||
| if: ${{ inputs.build_variant != 'asan' }} |
There was a problem hiding this comment.
I have some open PRs that will support a different solution here:
- Use configure_pytorch_release_matrix.py to drive the CI job matrix #6082
- Add optional JAX release build toggle #6117
multi_arch_release_asan.yml will set build_pytorch: false and build_jax: false which will propagate through all the workflows.
We shouldn't have something different here for jax than we have for pytorch (see line 234 just above)
Sure @ScottTodd , This will drop then since we will solve it with toggle. |
|
Closing this since the other solutions are in progress. |
2 participants
Description
Fixes: #6210
JAX test jobs are failing with:
This happens because ASan-instrumented ROCm tarballs are being used to build JAX wheels, but the test environment cannot load the ASan runtime correctly.
Changes
if: ${{ inputs.build_variant != 'asan' }}guard to thetrigger_release_jax_wheelsjob inmulti_arch_release_linux.yml.This prevents dispatching JAX builds for ASan nightlies while keeping normal builds unaffected.
Testing