Enable --include-iree-libs fetch and -DTHEROCK_ENABLE_IREE_LIBS build by default#5093
Open
Enable --include-iree-libs fetch and -DTHEROCK_ENABLE_IREE_LIBS build by default#5093
--include-iree-libs fetch and -DTHEROCK_ENABLE_IREE_LIBS build by default#5093Conversation
Note: iree-compiler has `disable_platforms = ["windows"]` in BUILD_TOPOLOGY.toml still
marbre
approved these changes
May 7, 2026
Member
marbre
left a comment
There was a problem hiding this comment.
Yeah, another LLVM copy by default ;)
Member
Author
|
cc a few people from the discussion on ROCm/rocm-libraries#6903: @jayhawk-commits @BrianHarrisonAMD @geomin12 (review if you'd like) |
BrianHarrisonAMD
approved these changes
May 7, 2026
AaronStGeorge
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Multi-arch CI is now enabled by default in TheRock, so we should make the default for developers match what CI is doing.
See:
fusilliproviderin rocm-libraries CI rocm-libraries#6903Technical Details
--stagemode of fetching sources will pay this extra cost if they don't explicitly opt-out of the new setting.-DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_*=ONfor some subset (as rocm-libraries already does) or-DTHEROCK_ENABLE_IREE_LIBS=OFFiree-compilerartifact is still annotated withdisable_platforms = ["windows"]inBUILD_TOPOLOGY.toml, so the builds remain disabled thereTest Plan
Submission Checklist