Skip to content

Enable --include-iree-libs fetch and -DTHEROCK_ENABLE_IREE_LIBS build by default#5093

Open
ScottTodd wants to merge 2 commits intoROCm:mainfrom
ScottTodd:iree-default-enable
Open

Enable --include-iree-libs fetch and -DTHEROCK_ENABLE_IREE_LIBS build by default#5093
ScottTodd wants to merge 2 commits intoROCm:mainfrom
ScottTodd:iree-default-enable

Conversation

@ScottTodd
Copy link
Copy Markdown
Member

@ScottTodd ScottTodd commented May 6, 2026

Motivation

Multi-arch CI is now enabled by default in TheRock, so we should make the default for developers match what CI is doing.

See:

Technical Details

  • This will add 45s+ to initial clone time when using the legacy fetch options.
    • Repositories that have not yet migrated to the --stage mode of fetching sources will pay this extra cost if they don't explicitly opt-out of the new setting.
  • This will enable a few new subproject builds (IREE's LLVM, fusilli, etc.) by default which are already enabled for multi-arch CI.
    • Repositories that have not yet migrated to multi-arch CI may want to opt-out with -DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_*=ON for some subset (as rocm-libraries already does) or -DTHEROCK_ENABLE_IREE_LIBS=OFF
    • The iree-compiler artifact is still annotated with disable_platforms = ["windows"] in BUILD_TOPOLOGY.toml, so the builds remain disabled there

Test Plan

Submission Checklist

ScottTodd added 2 commits May 6, 2026 14:41
Note: iree-compiler has `disable_platforms = ["windows"]` in BUILD_TOPOLOGY.toml still
@ScottTodd ScottTodd added the ci:run-non-multi-arch Opt-in to running non-multi-arch CI on a pull request label May 6, 2026
Copy link
Copy Markdown
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, another LLVM copy by default ;)

@ScottTodd ScottTodd marked this pull request as ready for review May 7, 2026 15:17
@ScottTodd ScottTodd requested a review from AaronStGeorge May 7, 2026 15:18
@ScottTodd
Copy link
Copy Markdown
Member Author

cc a few people from the discussion on ROCm/rocm-libraries#6903: @jayhawk-commits @BrianHarrisonAMD @geomin12 (review if you'd like)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:run-non-multi-arch Opt-in to running non-multi-arch CI on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants