Open
Conversation
TorreZuk
approved these changes
May 6, 2026
Contributor
TorreZuk
left a comment
TorreZuk
left a comment
There was a problem hiding this comment.
New tests have been added, and can reduce after variability of runs is reduced.
ScottTodd
requested review from
geomin12 and
jayhawk-commits
and removed request for
ScottTodd and
marbre
Contributor
|
Please add some details on how many more tests were added and how much longer the execution time needs. Eventually, this can be captured automatically with prolense. CC @amd-shiraz |
Author
The newest tests are for SYTRS and SYTRS2; there are 3456 new test cases. I was able to run these tests in about 47 seconds on gfx942. But because of the test variance on TheRock CI, we also saw individual test cases taking multiple seconds in the nightly tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Nightly rocSOLVER tests intermittently time out on theRock CI. The variance in test time will need to be investigated, but increasing the time out value was suggested as a short-term solution.
Technical Details
Increased test time out for rocSOLVER from 60 mins to 120 mins.
Submission Checklist