Skip to content

[ci] Fixing dep rpm packages for forked upload#5066

Draft
geomin12 wants to merge 7 commits intoROCm:mainfrom
geomin12:users/geomin12/fix-rpm-deb
Draft

[ci] Fixing dep rpm packages for forked upload#5066
geomin12 wants to merge 7 commits intoROCm:mainfrom
geomin12:users/geomin12/fix-rpm-deb

Conversation

@geomin12
Copy link
Copy Markdown
Contributor

@geomin12 geomin12 commented May 5, 2026

Noticied that RPM and DEB packages fail to upload: https://github.com/ROCm/TheRock/actions/runs/25237692770/job/74244690857?pr=4998 due to the build image not correctly configured (or even used!).

This change uses a proper docker image as well as proper credentials for forked repos

Copy link
Copy Markdown
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. That would do it... Thanks.

Please wait for CI to complete on this. I have some doubts about the "Install Python requirements" and "Install System requirements" steps working in the container 😅

@ScottTodd
Copy link
Copy Markdown
Member

Oops, CI didn't run on this. Need to edit

# GitHub workflow file patterns that are considered CI-related.
# Changes to workflow files matching these patterns will trigger CI runs,
# as they may affect the CI pipeline itself.
_GITHUB_WORKFLOWS_CI_PATTERNS = [
"setup.yml",
"ci*.yml",
"multi_arch*.yml",
"build*artifact*.yml",
"build*ci.yml",
"build*python_packages.yml",
"test*artifacts.yml",
"test_rocm_wheels.yml",
"test_sanity_check.yml",
"test_component.yml",
]
too

(or you can trigger the workflow directly to skip past the rest of the CI jobs)

outputs:
package_install_url: ${{ steps.upload-packages.outputs.package_repository_url }}
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:702a5133851e6d1daf1207d2c9fbb01c2667914a5b6dc5a01faeb3ce66ea6421
Copy link
Copy Markdown
Contributor

@nunnikri nunnikri May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current job needs to be run on Ubuntu. Ubuntu2404/Ubuntu2204

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Then this job might need to set the AWS_SHARED_CREDENTIALS_FILE env var per https://github.com/ROCm/TheRock/blob/main/docs/development/s3_buckets.md#authentication ... though I would expect the credential file on the runners to already be used by default without that 🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah it isn't as it's only used to docker volume mounts, i'll fix

"test_rocm_wheels.yml",
"test_sanity_check.yml",
"test_component.yml",
"build_native*packages.yml",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, CI didn't run on this.

Thanks for the fix here. I also just sent #5089 for a general solution

@geomin12 geomin12 marked this pull request as draft May 6, 2026 23:57
@nunnikri nunnikri requested review from ammallya and raramakr May 7, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

3 participants