[ci] Fixing dep rpm packages for forked upload#5066
[ci] Fixing dep rpm packages for forked upload#5066
Conversation
ScottTodd
left a comment
There was a problem hiding this comment.
Oh. That would do it... Thanks.
Please wait for CI to complete on this. I have some doubts about the "Install Python requirements" and "Install System requirements" steps working in the container 😅
|
Oops, CI didn't run on this. Need to edit TheRock/build_tools/github_actions/configure_ci_path_filters.py Lines 165 to 179 in d41dc84 (or you can trigger the workflow directly to skip past the rest of the CI jobs) |
| outputs: | ||
| package_install_url: ${{ steps.upload-packages.outputs.package_repository_url }} | ||
| container: | ||
| image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:702a5133851e6d1daf1207d2c9fbb01c2667914a5b6dc5a01faeb3ce66ea6421 |
There was a problem hiding this comment.
Current job needs to be run on Ubuntu. Ubuntu2404/Ubuntu2204
There was a problem hiding this comment.
Ah. Then this job might need to set the AWS_SHARED_CREDENTIALS_FILE env var per https://github.com/ROCm/TheRock/blob/main/docs/development/s3_buckets.md#authentication ... though I would expect the credential file on the runners to already be used by default without that 🤔
There was a problem hiding this comment.
ah it isn't as it's only used to docker volume mounts, i'll fix
| "test_rocm_wheels.yml", | ||
| "test_sanity_check.yml", | ||
| "test_component.yml", | ||
| "build_native*packages.yml", |
There was a problem hiding this comment.
Oops, CI didn't run on this.
Thanks for the fix here. I also just sent #5089 for a general solution
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Noticied that RPM and DEB packages fail to upload: https://github.com/ROCm/TheRock/actions/runs/25237692770/job/74244690857?pr=4998 due to the build image not correctly configured (or even used!).
This change uses a proper docker image as well as proper credentials for forked repos