Add multi-arch (flat) upload mode for Python packages and tarballs#5058
Open
araravik-psd wants to merge 4 commits intomainfrom
Open
Add multi-arch (flat) upload mode for Python packages and tarballs#5058araravik-psd wants to merge 4 commits intomainfrom
araravik-psd wants to merge 4 commits intomainfrom
Conversation
marbre
approved these changes
May 6, 2026
Member
marbre
left a comment
There was a problem hiding this comment.
Approving as I assume the functionality has been validated manually. @HereThereBeDragons please look more closely.
Solely looking at the changes, the functionality added seems mostly covered with build_tools/github_actions/publish_rocm_to_release_buckets.py. It should at least be possible to reuse code _therock_utils.storage_location and _therock_utils.storage_backend in the script. This script is also lacking tests and I am only approving as this is time sensitive. Before landing I expect to
- Evaluate if reusing the functions pointed to above is reasonable. If it is, file an issue for a future refactoring.
- If it is not, file an issue to add tests specifically as this is lacking any test so far.
Issues should be linked and PR description can be tidied up a bit further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly adds
Introduced --multi-arch flag
Changes S3 key construction:
Default:
<prefix>/<arch>/<package>Multi-arch:
<prefix>/<package>Updated --use-release-buckets handling:
Default → v3/whl/, v3/tarball/
Multi-arch → v4/whl/, v4/tarball/
Ensures both Python packages and tarballs are uploaded to the correct layout
Upload logic remains flat:
<prefix>/<tarball>Destination changes based on selected prefix (standard vs multi-arch)
Testing:
https://gist.github.com/araravik-psd/904784e6f08af6c1fd79aab6b5d16da5