Draft
Conversation
1 task
dileepr1
added a commit
to ROCm/rocm-systems
that referenced
this pull request
May 6, 2026
## Motivation The goal is to categorize tests at the component level, enabling TheRock CI to invoke a common test_runner with specified categories to run the appropriate tests. More details available at [test_filtering.md](https://github.com/ROCm/TheRock/blob/main/docs/development/test_filtering.md). ## Technical Details - These following are the changes made in rocm-systems: - Add test_categories.yaml in rocrtst - Add the parser - parse_test_categories.py, and the associated the function call in associated TestCategories.cmake at rocm-systems/shared/ctest - The framework to make the parser call and create ctest entries and copy CTestTestfile.cmake over to 'bin/rocrtst' This works together with the companion PR [#4812](ROCm/TheRock#4812) at TheRock side. ## Test Plan Confirm rocrtst is run with correct filters for the corresponding categories. ## Test Result Sample run: https://github.com/ROCm/TheRock/actions/runs/24973684590/job/73132282952?pr=4812 ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
saleelk
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
May 7, 2026
## Motivation The goal is to categorize tests at the component level, enabling TheRock CI to invoke a common test_runner with specified categories to run the appropriate tests. More details available at [test_filtering.md](https://github.com/ROCm/TheRock/blob/main/docs/development/test_filtering.md). ## Technical Details - These following are the changes made in rocm-systems: - Add test_categories.yaml in rocrtst - Add the parser - parse_test_categories.py, and the associated the function call in associated TestCategories.cmake at rocm-systems/shared/ctest - The framework to make the parser call and create ctest entries and copy CTestTestfile.cmake over to 'bin/rocrtst' This works together with the companion PR [#4812](ROCm/TheRock#4812) at TheRock side. ## Test Plan Confirm rocrtst is run with correct filters for the corresponding categories. ## Test Result Sample run: https://github.com/ROCm/TheRock/actions/runs/24973684590/job/73132282952?pr=4812 ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Restore rocm-systems gitlink to main's commit so this branch follows main's behavior instead of pointing to a different location. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist