[HIPIFY][#2402] Warn users for non-self-contained header hipification in isolation - Part 2#2447
Draft
ranapratap55 wants to merge 1 commit intoROCm:amd-developfrom
Conversation
…tion in isolation - Part 2
ranapratap55
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up PR to #2402 for implicit local header hipification by default.
hipify-clang sample.cuautomatically detects and hipifies all local headers recursively, no flags needed.Purpose
#2402
Added clear, actionable warning when a header file fails hipification, explaining the likely cause and suggesting the correct approach.