optimized fast path by reducing register use and vectorize on normal …#436
Open
optimized fast path by reducing register use and vectorize on normal …#436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR improves the performance of the FlyDSL RMSNorm kernel by addressing inefficiencies observed in production-like workloads (e.g., GPT-style shapes such as N=2880).
The previous implementation suffered from:
The goal of this PR is to:
Technical Details
This PR introduces several optimizations to the RMSNorm kernel:
Test Plan
The unit-test on test_rmsnorm.py within FlyDSL repo. Run python -m tests.kernels.test_rmsnorm
Test Result
================
Running RMSNorm Tests
Testing RMSNorm (M=32768, N=8192, dtype=bf16)
Launching kernel...
[W424 19:43:23.196708004 collection.cpp:1133] Warning: ROCTracer produced duplicate flow start: 1 (function operator())
Kernel avg time: 0.2125 ms via run_perftest (warmup=10, iters=100)
Bandwidth: 5052.71 GB/s
Max absolute error: 1.56e-02 (atol=0.02)
PASSED
================================================================================
ALL TESTS PASSED