Open
Conversation
Collaborator
|
CI failed. @amd-wsung102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FlyDSL currently does not have a TopK Gating Softmax kernel, but the operations in this kernel are used in models like GPT-OSS 120B.
Relevant Files
kernels/topk_gating_softmax_kernel.py- topk gating softmax kerneltests/kernels/test_topk_gating_softmax.py- unit test for the kernelOptimizations
Test Result - Kernel Level
Tested on MI350. Unit test passed.
Around 1.4x-1.5x performance improvement over the vLLM TopKGatingSoftmax kernel, which is used in models like GPT-OSS 120B. Also 1.1x-1.6x performance improvement over the current AITER version.
Test Result - E2E GPT-OSS 120B
Config: 1k8k / TP=8 / BS = 4
Submission Checklist