Merged
Conversation
Contributor
Author
|
Fast charging is broken for now I'm working on fixing it |
af61fc1 to
e663f8d
Compare
sunshineinabox
commented
Mar 26, 2026
| charge-full-design-microamp-hours = <5000000>; | ||
| voltage-min-design-microvolt = <3400000>; | ||
| voltage-max-design-microvolt = <4350000>; | ||
| constant-charge-current-max-microamp = <2040000>; |
Contributor
Author
There was a problem hiding this comment.
This is very conservative while charging on fast charger vendor pulls 3000mA, we don't have a software thermistor in our driver so lower limit is fine. This will require a one line patch to make sure it actually uses this value.
e1840b8 to
13187ea
Compare
e899a1d to
4e04966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Additional Context
AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO