Adjustable volume and brightness steps

[dusthillresident]

Make it so that the settings keys 'audio.volume_step' and 'display.brightness_step' specify the percentage by which the volume and display brightness should be stepped. If those keys are not set, the percentage step defaults to 5% as before.

I'm suggesting this change because I found that the previous default step of 5% gave me a choice between "almost inaudible" and "way too loud", both through headphones and through the speaker. The brightness step of 5% wasn't very comfortable either. Thanks for reviewing.

[spycat88]

I'm sure that volume and brightness steps is configured in ES as well because when I did the initial rework it would change in 1% increments and I ended up hardcoding it to 10 steps.

[dusthillresident]

I'm sure that volume and brightness steps is configured in ES as well because when I did the initial rework it would change in 1% increments and I ended up hardcoding it to 10 steps.

I'm not sure what you mean, sorry, do you mean that emulationstation has its own options or settings for changing the brightness and volume steps? I didn't see anything like that in the menus, and I haven't looked at the code for the emulationstation stuff.

I did notice that once I implemented the changes, changing the volume in the emulationstation UI incremented in the same step as when I just pressed the volume keys, so that seemed good.

[porschemad911]

@dusthillresident what device is this again? We have not had any other reports and I have not noticed this on any of my devices, speakers or headphones.

[dusthillresident]

@dusthillresident what device is this again? We have not had any other reports and I have not noticed this on any of my devices, speakers or headphones.

"Game Console R36H" - Rocknix RK3326 'a' .img
"Game Console R36S" - Rocknix RK3326 'b' .img
"Gaminja ANS13" - Rocknix RK3326 'b' .img

Koss portapro headphones

All of them are the same experience - with volume step of 5%, I've got a choice between "inaudible", "a bit louder than what I really want", and "WAY TOO LOUD", and nothing in between. It's less severe with the speakers but still doesn't give me a comfortable choice.

It looks like in the first 30% of the volume setting range, 5% step increases the volume in increments of ~6.4 decibels (tested by plugging it into my line-in and recording the signal)

Re: "we don't have other reports of this", it's possible this is because

• Rocknix is a niche project with not especially many people getting involved in it
• Other people with this issue might have found a low tech solution like using a headphone cable with a volume attenuator wheel (I did this to begin with) and then just didn't bother looking further
• Other people experiencing this might not have been bothered enough, or had the time or the patience enough, to go to the hassle of making a bug report or a pull request etc.

[r3claimer]

@spycat88 @porschemad911

I am fine with this change if it does not alter the default behavior. Thoughts?

[porschemad911]

I'm fine with it. Have not personally tested this codebase but it all looks fine.

[spycat88]

Can you follow the code style for the rest of the file and use a single line for if; then

[r3claimer]

@dusthillresident

I am going to close this. Feel free to reopen if you make the changes spycat requested.