Fix +1 line with fullscreen#143
Open
vid512 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project seems dead, but since I like it a lot, I'll try this PR anyway.
This fixes the problem with last line being partially invisible in fullscreen mode. See #138
This was caused by RendererGridToPixelSize() assuming that window style is WS_OVERLAPPEDWINDOW, which is explicitly disabled in ToggleFullscreen for fullscreen windows. Also, we don't want "grid_resize" message handler to round down window size to fint size. This causes Windows Taskbar to appear over Nvy window.
So, the solution is not to resize window at all upon receiving "grid_resize" message, when the window is fullscreen (detected by checking window style, see ToggleFullscreen implementation).