Skip to content

feat(compare): add dependencies section scoped by sector - #1032

Merged
jacobvjk merged 1 commit into
epic/v2from
feat/compare-dependencies
Oct 27, 2026
Merged

jacobvjk merged 1 commit into
epic/v2from
feat/compare-dependencies

Conversation

@jacobvjk

Copy link
Copy Markdown
Collaborator

Closes #1030

What changes

The compare page gets a Dependencies section, between Key Features and Geographies.

  • All 10 dependency categories always render, labelled once across the columns (the Key Features pattern), so rows line up between pathways. Under each label, each pathway shows its evidence badge and description; a category it records nothing for shows "No information".
  • The section follows the Sector selection in the scope header, since dependencies are recorded per sector. Geography does not apply (the schema keeps dependencies out of geography scoping); the heading's info tooltip says so.
  • A pathway with no dependencies for the selected sector gets one note at the top of its column ("This pathway has no dependencies recorded for Steel.") and blank cells below, rather than ten "No information" cells.
  • If no compared pathway records anything for the sector, the section shows a single sentence instead of empty rows.

Sector availability: a shared sector is now selectable when any column has plot data or recorded dependencies for it, via the existing scopeAvailability helper — the rule the detail page's ribbon already uses. The Geographies / Sectors / Benchmark Metrics coverage badges keep their timeseries-only meaning.

EvidenceBadge is now exported from DependenciesTable so both pages share one evidence colour scale.

Tests

  • ComparisonDependencies.test.tsx: rows match the schema's enum in order; sector filtering; "No information" cells; repeated categories stack; per-column note with blank cells; whole-section empty states.
  • ComparisonPage.test.tsx: section order, sector switching, and a sector selectable for its dependencies alone.

Checked in the browser with IEA NZE 2025 + VN EREA NZ + NGFS NZ2050 REMIND on Steel (column note case) and two NGFS pathways on Power.

Open point

The grey "No information" pill looks similar to the grey "No evidence" evidence badge. It matches what Key Features uses for missing values; happy to switch it to plain muted text if that reads better.

Overlap

#998 (key-feature resolver) also touches ComparisonPage; any conflict should be small.

🤖 Generated with Claude Code

Shows every dependency category once across the columns, with each
pathway's evidence and description underneath, for the sector selected
in the scope header. A pathway with nothing for that sector gets one
note at the top of its column.

A shared sector is now selectable when any column has plot data or
recorded dependencies for it, the rule the detail page already uses.

Closes #1030

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Expected version change and release notes

🚨 WARNING: This PR is not expected to trigger a new version

To trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-1032.westus2.2.azurestaticapps.net

@jacobvjk
jacobvjk merged commit 6d6f0d2 into epic/v2 Oct 27, 2026
11 checks passed
@jacobvjk
jacobvjk deleted the feat/compare-dependencies branch October 27, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants