Repository navigation
chore(geography): use the policy wording for the regional disclaimer - #1024
Merged
Merged
Conversation
Closes #917 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Expected version change and release notes🚨 WARNING: This PR is not expected to trigger a new versionTo trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/ |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused text and test changes match the stated requirements, with no identified blocking issues.
No open issues 🎉
What changed in this PR
Updates the shared regional disclaimer to the RMI policy wording requested in #917, keeping it consistent across the search, detail, compare, and Methodology pages.
Changes:
- Replaces the shared disclaimer with the policy text.
- Simplifies the Methodology note by removing the territorial-claims sentence.
- Updates tests to check that the note appears once in a single italic block.
| File | Description |
|---|---|
src/utils/geographyUtils.ts |
Updates the shared disclaimer and its explanatory comment. |
src/pages/resources/ResourcesMethodologyPage.tsx |
Uses only the policy disclaimer in the italicized note. |
src/pages/resources/ResourcesMethodologyPage.test.tsx |
Adjusts assertions for the new note and removed sentence. |
Review effort: Balanced
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-1024.westus2.2.azurestaticapps.net |
AlexAxthelm
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #917
What changes
The regional disclaimer now uses the wording from the RMI policy doc:
It replaces "The mapping of any individual country or territory to a region reflects the mappings of the model used in the pathway. It does not reflect any opinion of RMI."
The text lives in one shared constant (
REGION_MAPPING_DISCLAIMER), so all four places update together:On the Methodology page the note is now just "Note: …" with the new wording; the extra sentence "RMI does not make any statements on country delineations and/or conflicting territorial claims." is removed.
Testing
ResourcesMethodologyPage.test.tsxupdated: the note shows the new wording once, in a single italic block, without the territorial-claims sentence.npx vitest run,npm run lint,npm run format:checkall pass.Note: closing keywords don't fire on PRs into
epic/v2; #917 closes when #937 merges tomain, or can be closed by hand.🤖 Generated with Claude Code