Skip to content

chore(geography): use the policy wording for the regional disclaimer - #1024

Merged
jacobvjk merged 1 commit into
epic/v2from
chore/regional-disclaimer
Oct 27, 2026
Merged

jacobvjk merged 1 commit into
epic/v2from
chore/regional-disclaimer

Conversation

@jacobvjk

Copy link
Copy Markdown
Collaborator

Closes #917

What changes

The regional disclaimer now uses the wording from the RMI policy doc:

Country and regional representations follow the conventions used in the underlying data sources and do not reflect any institutional point of view by RMI.

It replaces "The mapping of any individual country or territory to a region reflects the mappings of the model used in the pathway. It does not reflect any opinion of RMI."

The text lives in one shared constant (REGION_MAPPING_DISCLAIMER), so all four places update together:

  • footnote under the Geography filter on the search page
  • Geographies (i) tooltip on the pathway detail page
  • Geographies (i) tooltip on the compare page
  • note on the Methodology page

On the Methodology page the note is now just "Note: …" with the new wording; the extra sentence "RMI does not make any statements on country delineations and/or conflicting territorial claims." is removed.

Testing

  • ResourcesMethodologyPage.test.tsx updated: the note shows the new wording once, in a single italic block, without the territorial-claims sentence.
  • The other disclaimer tests compare against the shared constant and pass unchanged.
  • npx vitest run, npm run lint, npm run format:check all pass.
  • Not checked in the browser (text-only change).

Note: closing keywords don't fire on PRs into epic/v2; #917 closes when #937 merges to main, or can be closed by hand.

🤖 Generated with Claude Code

Closes #917

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jacobvjk
jacobvjk requested a balanced review from Copilot October 26, 2026 14:15
@github-actions

Copy link
Copy Markdown

Expected version change and release notes

🚨 WARNING: This PR is not expected to trigger a new version

To trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused text and test changes match the stated requirements, with no identified blocking issues.

No open issues 🎉

What changed in this PR

Updates the shared regional disclaimer to the RMI policy wording requested in #917, keeping it consistent across the search, detail, compare, and Methodology pages.

Changes:

  • Replaces the shared disclaimer with the policy text.
  • Simplifies the Methodology note by removing the territorial-claims sentence.
  • Updates tests to check that the note appears once in a single italic block.
File Description
src/​utils/​geographyUtils.ts Updates the shared disclaimer and its explanatory comment.
src/​pages/​resources/​ResourcesMethodologyPage.tsx Uses only the policy disclaimer in the italicized note.
src/​pages/​resources/​ResourcesMethodologyPage.test.tsx Adjusts assertions for the new note and removed sentence.

Review effort: Balanced

@jacobvjk
jacobvjk requested a review from AlexAxthelm October 26, 2026 14:27
@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-1024.westus2.2.azurestaticapps.net

@jacobvjk
jacobvjk merged commit 143b79a into epic/v2 Oct 27, 2026
39 of 42 checks passed
@jacobvjk
jacobvjk deleted the chore/regional-disclaimer branch October 27, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants