Repository navigation
Docs/batch update - #61
Merged
Merged
Conversation
Add guidance on running test scenarios + cases-archive folder
New CEPM/guidance/fixing-reeds-issues.md walks through fixing a bug in the ReEDS model code: branch from the working branch, record the issue in known-reeds-issues.md, fix and verify it, log any upstream-file changes in reeds-to-cepm-log.md, and open a pull request. Follows the layout of running-test-scenarios.md and uses fix/ra-plot-logging (PR #60) as a worked example. Indexed in CEPM/README.md. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The guide was added without a row in the guidance/ table, which CEPM/README.md uses to index every file in CEPM/. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Finishes the "What is a test scenario?" section, which stopped mid-sentence, and fills in the empty Objectives section. Adds the traps a first-time user hits: keep cleanup_level at 0 in every column (otherwise a background -m run hangs on an unseen prompt), define all three columns per stem with GSw_CEPM_TgCap set as multistep_cases.py expects, dry-run with -t first, check each run folder for outputs/outputs.h5 rather than trusting runreeds.py's success message, and don't pass -r through run_cepm.ps1. Replaces the "bug with -x" note with the actual rule: -x compares every runs/<BatchName>_* folder, so each batch needs a new name. Also adds an example cases-file layout, -u and -o, a typical WECC-SW run time, where to look when a run fails, and which doc to update for each outcome in step 7. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The test workflow cannot perform its stated comparison, and several records contain placeholders, inaccurate guidance, and broken links.
Review effort: Balanced
Findings: 7
Open (7)
What changed in this PR
Adds CEPM workflow guidance, issue records, batch documentation, and temporary-file exclusions.
Changes:
- Documents test-scenario and ReEDS issue-fixing workflows.
- Records recent model issues, batch results, and a regional decision.
- Ignores generated multistep-run files.
| File | Description |
|---|---|
.gitignore |
Ignores multistep temporary files. |
CEPM/README.md |
Indexes new guidance. |
CEPM/known-reeds-issues.md |
Adds issue index and investigations. |
CEPM/guidance/running-test-scenarios.md |
Adds test-scenario workflow. |
CEPM/guidance/fixing-reeds-issues.md |
Adds issue-fixing workflow. |
CEPM/decisions/README.md |
Updates decision process. |
CEPM/decisions/202XXXXX-decision-template.md |
Revises decision template. |
CEPM/decisions/20260929-state-regions.md |
Records state-region decision. |
CEPM/cases-archive/placeholder.csv |
Establishes cases archive. |
CEPM/batch-log.md |
Records September 2026 batches. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Tyler Fitch <95767834+ty-fi@users.noreply.github.com>
ty-fi
commented
Sep 29, 2026
ty-fi
marked this pull request as ready for review
September 29, 2026 20:07
samhuestis
approved these changes
Sep 30, 2026
Collaborator
There was a problem hiding this comment.
@ty-fi What's going on here with the cases*__*.csv? Is this just to ignore one-off test files, since the normal naming schema for case files is case_{type}.csv?
Collaborator
There was a problem hiding this comment.
Nvm, this is a temp case file created by run_cepm.ps1
samhuestis
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation across a few different categories for this repo:
cases-archivefolder