Skip to content

Boundary streams and TransmissionCompressor - #23

Merged
mbarlow12 merged 2 commits into
mainfrom
fix/boundary-and-transmission-compressor
Sep 16, 2025
Merged

mbarlow12 merged 2 commits into
mainfrom
fix/boundary-and-transmission-compressor

Conversation

@mbarlow12

@mbarlow12 mbarlow12 commented Sep 15, 2025 •

Copy link
Copy Markdown

This PR addresses 2 items:

  • Boundary instances exit their input stream loop if any one is "uninitialized" resulting in the loss of subsequent stream outputs
  • the TransmissionCompressor only accepts a single gas input, but multiple gas streams with other names may exit the ProductionBoundary

Fixes:

  • use continue in Boundary to iterate through all input streams and set their commensurate output
  • use ".*gas" regex in declaring TransmissionCompressor input streams
    • Note: this is due to the ProductionBoundary now passing both export gas and gas

Fixes #21

…s in Boundary

fix(transmission_compressor): combine all gas input streams using regex matching
- add "prod exported gas" stream in opgee.xml
- comment default values for crude oil storage attributes
- broaden input requirement pattern in transmission compressor process
@mbarlow12
mbarlow12 requested a review from lloyd-rmi September 15, 2025 16:27

@lloyd-rmi lloyd-rmi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mbarlow12
mbarlow12 merged commit 6898900 into main Sep 16, 2025
2 of 6 checks passed
@mbarlow12
mbarlow12 deleted the fix/boundary-and-transmission-compressor branch September 16, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boundaries not copying all input streams to outputs

2 participants