This repository was archived by the owner on Jun 15, 2026. It is now read-only.
feat: prevent user form login before conforming his email#56
Merged
RMCampos merged 3 commits intoMay 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a complete "email not confirmed" flow for user login. It introduces backend validation to prevent unconfirmed users from logging in, provides a clear error message, and updates the frontend to display a resend confirmation email button when appropriate. Additionally, the changes enhance internationalization support for the new messages and improve test coverage for these scenarios.
Backend: Email Confirmation Enforcement
EmailNotConfirmedExceptionand updatedAuthServiceto throw this exception if a user attempts to log in without confirming their email. This ensures only confirmed users can authenticate. [1] [2] [3]AuthServiceTestto cover both the confirmed and unconfirmed email login scenarios, ensuring the new logic is robust and well-tested. [1] [2] [3] [4] [5]Frontend: Login Form and Resend Flow
LoginFormcomponent to detect the "Email not confirmed!" error, display a user-friendly message, and show a "Resend Confirmation Email" button. The resend button is also shown after a successful resend action. [1] [2] [3] [4] [5] [6] [7]LoginForm.test.tsxto verify that the resend button appears when login fails due to an unconfirmed email.Internationalization and Server Response Mapping
serverResponsesandserverResponsesTranslationsto include keys and translations for "Email not confirmed!" and "Confirmation email re-sent! Please check the spam folder." in multiple languages, ensuring a consistent user experience. [1] [2] [3] [4]Other Minor Fixes
SidebarProvider.test.tsxto expect the correct page route after navigation.