This repository was archived by the owner on Jun 15, 2026. It is now read-only.
fix: mailgun 401 error#55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the email service integration for Mailgun in the backend, replacing the legacy
RestTemplate-based implementation with the newerRestClientAPI. It also updates the related tests and environment variable handling to align with these changes.Mailgun Email Service Refactor:
MailgunEmailServicefrom usingRestTemplateto the modernRestClientAPI, simplifying HTTP request handling and improving error logging. The constructor now takes aRestClient.Builderand sets up base URL, authentication, and error handling directly. [1] [2]sendEmailmethod to userestClient's fluent API for sending emails, removing manual header and entity construction, and improving error handling for both HTTP and unexpected exceptions. [1] [2]Testing Updates:
MailgunEmailServiceTestto mockRestClientand its builder, replacing allRestTemplateusage and verifications. Introduced a helper method to set up the mock call chain for the new client. [1] [2] [3] [4] [5]Dependency and Environment Variable Adjustments:
spring-boot-starter-maildependency frompom.xmlsince Mailgun is now handled directly via HTTP.MAILGUN_APIKEYandSECURITY_KEYas environment variables for the server container.