core: add DEFAULT_APP_ENTRY to select main() function#8533
Closed
jia200x wants to merge 1 commit into
Closed
Conversation
jnohlgard
requested changes
Feb 7, 2018
| LOG_INFO("main(): This is RIOT! (Version: " RIOT_VERSION ")\n"); | ||
|
|
||
| LOG_INFO(DEFAULT_APP_ENTRY_NAME "(): This is RIOT! (Version: " RIOT_VERSION ")\n"); | ||
| main(); |
11ae0e3 to
b4263b8
Compare
b4263b8 to
5fda68c
Compare
Contributor
|
I don't quite agree with the use cases. Using this define, one other function can be selected (instead of main). This could simple be solved by the corresponding modules just defining "main()", instead of an application. |
Member
|
@jia200x do you agree with the objections of @kaspar030 or shall we ask for another review? |
Member
Author
|
@tcschmidt I agree. Let's close this PR and continue in favour of #9105 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR/RFC adds a mechanism to change the default entry point to the user main function.
To change main entry point simply define DEFAULT_APP_ENTRY to a different function (by default, will call main() ).
Why?
I found this use cases:
I also added a mechanism to print the name of the function, which I'm still not 100% sure if it's the way to go (message should still be there?, etc).
All feedback will be really appreciated!