Skip to content

sys/xtimer: Fix possible race condition in xtimer where sleep is added to the wrong list. #7116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DipSwitch wants to merge 1 commit into from
Closed

sys/xtimer: Fix possible race condition in xtimer where sleep is added to the wrong list. #7116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions sys/xtimer/xtimer_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,11 @@ static inline void _lltimer_set(uint32_t target)

int _xtimer_set_absolute(xtimer_t *timer, uint32_t target)
{
unsigned state = irq_disable();
if (_is_set(timer)) {
_remove(timer);
}

uint32_t now = _xtimer_now();
int res = 0;

Expand All @@ -178,16 +183,12 @@ int _xtimer_set_absolute(xtimer_t *timer, uint32_t target)
timer->next = NULL;
if ((target >= now) && ((target - XTIMER_BACKOFF) < now)) {
/* backoff */
irq_restore(state);
xtimer_spin_until(target + XTIMER_BACKOFF);
_shoot(timer);
return 0;
}

unsigned state = irq_disable();
if (_is_set(timer)) {
_remove(timer);
}

timer->target = target;
timer->long_target = _long_cnt;
if (target < now) {
Expand Down