Skip to content

netstats: several fixes#5236

Merged
OlegHahm merged 3 commits into
RIOT-OS:masterfrom
OlegHahm:netstats_fixes
Apr 3, 2016
Merged

netstats: several fixes#5236
OlegHahm merged 3 commits into
RIOT-OS:masterfrom
OlegHahm:netstats_fixes

Conversation

@OlegHahm

@OlegHahm OlegHahm commented Apr 3, 2016

Copy link
Copy Markdown
Member

Apparently while merging #4801 some things slipped through:

  • for netdev2_tap the existence of the callback was not checked before calling it for TX_COMPLETE
  • for enc28j60 the initialization of the netstats struct was introduced in the isr function instead of the init function
  • encx24j600 was completely missing the netstats

OlegHahm added 3 commits April 3, 2016 18:04
@OlegHahm
netdev2_tap: check for existence before calling cb
900528b
@OlegHahm
drivers enc28j60: correctly initialize netstats
4ba7392 
Driver's netstats should be initialize in init, not isr...
@OlegHahm
drivers encx24j600: introduce netstats
aa043a5 
This driver was missing netstats completely so far.
@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Apr 3, 2016
@OlegHahm OlegHahm added this to the Release 2016.04 milestone Apr 3, 2016
@miri64

miri64 commented Apr 3, 2016

Copy link
Copy Markdown
Member

Code-wise it looks good: ACK.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 3, 2016
@OlegHahm

OlegHahm commented Apr 3, 2016

Copy link
Copy Markdown
Member Author

Murdock is also happy. Let's go!

@OlegHahm OlegHahm merged commit 1b635e1 into RIOT-OS:master Apr 3, 2016
@OlegHahm OlegHahm deleted the netstats_fixes branch April 3, 2016 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@miri64 miri64

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2016.04

Development

Successfully merging this pull request may close these issues.

2 participants

@OlegHahm @miri64