sys/checksum: add ACCESS() attribute#22381
Open
maribu wants to merge 1 commit into
Open
Conversation
maribu
added
Type: enhancement
mguetschow
reviewed
Jun 15, 2026
maribu
added
the
AI: Helped
crasbe
reviewed
Jul 7, 2026
| } | ||
|
|
||
| void fletcher32_update(fletcher32_ctx_t *ctx, const void *data, size_t words) | ||
| void fletcher32_update(fletcher32_ctx_t *ctx, const uint16_t *data, size_t words) |
Contributor
There was a problem hiding this comment.
Does that count as "API change"? 🤔
Member
Author
There was a problem hiding this comment.
Technically yes.
Using this function correctly already required data to be aligned to uint16_t and words be the size in number of uint16_t. Failing to do so could cause bus errors (unaligned access) or out of bounds access.
Now instead of runtime failures, uncorrect use would fail at compile time.
crasbe
added
CI: ready for build
Annotated a functions in `sys/checksum` with the `access` attribute using the `ACCESS()` macro to allow GCC to perform better `-Wstringop-overflow` diagnostics. Co-authored-by: mguetschow <mikolai.guetschow@tu-dresden.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Annotated a functions in
sys/checksumwith theaccessattribute using theACCESS()macro to allow GCC to perform better-Wstringop-overflowdiagnostics.Testing procedure
The Ci should do the testing here
Issues/PRs references
#22380
Declaration of AI-Tools / LLMs usage:
Same as in #22380