pkg/nimble: fix the event queue size for nimble_adv_ext#18467
Merged
benpicco merged 1 commit intoAug 18, 2022
Conversation
If the Bluetooth 5 Advertising Extension is enabled by the `nimble_adv_ext` module, up to 3 events come in from the controller during connection establishment before they are processed by the host. The default size of the event queue `MYNEWT_VAL_BLE_TRANSPORT_EVT_COUNT` with only 2 entries is therefore too small and the connection establishment fails.
This was referenced Aug 18, 2022
Member
|
I fast-tracked #18466 as all other PRs would fail anyway until that gets merged. Sorry for the delay. |
benpicco
approved these changes
Aug 18, 2022
Contributor
Author
|
Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR increases the event queue size to fix a bug if module
nimble_adv_extis used.If the Bluetooth 5 Advertising Extension is enabled by the
nimble_adv_extmodule, the 3 eventscome in from the controller during connection setup before they are processed by the host. The default size of the event queue
MYNEWT_VAL_BLE_TRANSPORT_EVT_COUNTwith only 2 entries is too small and theLE Advertising Set Terminated eventis lost. Therefore, each connection setup fail. Increasing the event queue sizeMYNEWT_VAL_BLE_TRANSPORT_EVT_COUNTto 4 solves the problem.The problem was figured out when investigating the problems for
tests/nimble_*_extin PR #18439.Testing procedure
Flash two nRF52x nodes with
an check the results. Without this PR, the connection can't be established and command
ble infoshows the following results on both nodesWith this PR, the connection should be established and command
ble infoshould show the following results.Node1:
Node 2:
Issues/PRs references
Prerequisite for PR #18439